Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • O OpenFOAM-plus
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 339
    • Issues 339
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Development
  • OpenFOAM-plus
  • Issues
  • #420
Closed
Open
Issue created Mar 06, 2017 by Mattijs Janssens@MattijsMaintainer

timeActivatedFileUpdate FO takes two iterations to come into effect

(Exchange 358)

  • time to activate is exact so e.g. if time = 4.9999999 and activate time is set as 5 it will not trigger

  • checking for changed files is done before executing FOs so change of file is not picked up until next time step

  • improvement: forcibly re-check modified files in timeActivatedFileUpdate:

      cp(timeVsFile_[i].second(), destFile);
      mv(destFile, fileToUpdate_);
      lastIndex_ = i;
      const_cast<Time&>(time_).Time::readModifiedObjects();

(make sure to call Time::readModifiedObjects, not objectRegistry one)

  • other: if updated files are themselves FOs these need to do their action in their 'read' function or constructor. Alternative would be to know which FOs are new and execute only these. This sounds too convoluted.
Assignee
Assign to
Time tracking