ENH: print correct information of "out of bounding box" for sampledTriSurface field sampling

Attached example illustrating behavior

• sampling trisurface is out of mesh
• it gives badly formed BB error when used with fieldValue (and nothing with sampledSurfaces!)

test_GL575.tgz

Refer: EP#472

@mark @Mattijs

Issues:

• throwExceptions does not work in parallel. Can work around this (a bit) in functionObjectList constructor.
• bounding box when no intersection is illegal (- boundBox::empty does not behave as expected -> tests for -all- components of min > max)

mentioned in commit 87fdc2ea

The function object constructor (functionObjectList) intercepts any FatalError - this is how we catch set-up errors. The error message still says "Caught FatalError"+'Fatal Error' which is quite severe. Instead print 'Warning'?

Current:

--> FOAM Warning : 
    From function bool Foam::functionObjectList::read()
    in file db/functionObjects/functionObjectList/functionObjectList.C at line 786
    Caught FatalError 
--> FOAM FATAL ERROR: 
surfaceFieldValue fieldValue_sampledSurface: sampledSurface(inlet):
    Region has no faces

Proposal:

--> FOAM Warning : 
    From function bool Foam::functionObjectList::read()
    in file db/functionObjects/functionObjectList/functionObjectList.C at line 786
surfaceFieldValue fieldValue_sampledSurface: sampledSurface(inlet):
    Region has no faces

so inside functionObjectList catch print the raw message only: err.message().c_str() instead of << err

assigned to @andy

mentioned in commit 6bac4d33

Latest develop does not produce warning

If I set up a zero sized stl I get:

--> FOAM Warning : 
    From function Foam::treeBoundBox::treeBoundBox(const Foam::UList<Foam::Vector<double> >&, const labelUList&)
    in file meshes/treeBoundBox/treeBoundBox.C at line 94
    cannot find bounding box for zero-sized pointField, returning zero
--> FOAM Warning : 
surfaceFieldValue fieldValue_sampledSurface: sampledSurface(inlet):
    Region has no faces

    From function void Foam::functionObjects::fieldValues::surfaceFieldValue::initialise(const Foam::dictionary&)
    in file fieldValues/surfaceFieldValue/surfaceFieldValue.C at line 544.
    From function bool Foam::functionObjectList::read()
    in file db/functionObjects/functionObjectList/functionObjectList.C at line 840

Yes, I can replicate the both scenarios by simply rotating the mesh. Attached example. test_GL575-3.tgz

Refer the simpleFoam log.

Is it due to how tree search handles bounds/ alignment of coordinates?

• make sure FOAM_ABORT is not set.
• without it I get:

--> FOAM Warning : 
surfaceFieldValue fieldValue_sampledSurface: sampledSurface(inlet):
    Region has no faces

    From function void Foam::functionObjects::fieldValues::surfaceFieldValue::initialise(const Foam::dictionary&)
    in file fieldValues/surfaceFieldValue/surfaceFieldValue.C at line 552.
    From function bool Foam::functionObjectList::read()
    in file db/functionObjects/functionObjectList/functionObjectList.C at line 850

mentioned in commit 8751b9aa

Resolved by @Mattijs commit 8751b9aa

closed

mentioned in issue #1296 (closed)