Skip to content
Snippets Groups Projects

Feature streams cleanup

Merged Feature streams cleanup
feature-streams-cleanup into develop
Merged Mark OLESEN requested to merge feature-streams-cleanup into develop
  1. Jul 18, 2017
    • Mark OLESEN's avatar
      ENH: improved behaviour of input stream rewind (issue #534) · 730f0f8d
      Mark OLESEN authored 
      - clear error flags. Special handling for igzstream.
      730f0f8d
    • Mark OLESEN's avatar
      ENH: added OStringStream reset method (closes #534) · 48dea2ad
      Mark OLESEN authored 
      - resets the output buffer completely - implementing what rewind was
  likely meant to have accomplished for many use cases.

STYLE: OSHA1stream reset() for symmetry. Deprecate rewind().
      48dea2ad
    • Mark OLESEN's avatar
      ENH: make treatment of stream allocators more uniform (issue #532) · c12ca2b3
      Mark OLESEN authored 
      - use allocator class to wrap the stream pointers instead of passing
  them into ISstream, OSstream and using a dynamic cast to delete
  then. This is especially important if we will have a bidirectional
  stream (can't delete twice!).

STYLE:

- file stream constructors with std::string (C++11)

- for rewind, explicit about in|out direction. This is not currently
  important, but avoids surprises with any future bidirectional access.

- combined string streams in StringStream.H header.
  Similar to <sstream> include that has both input and output string
  streams.
      c12ca2b3