ENH: cleanup Pstream internal names, cull unneeded parameters
- Pstreams can be ascii/binary but are always currentVersion - rename UIPstream externalBuf_ to 'recvBuf_' for similar naming as PstreamBuffers and symmetry with UOPstream::sendBuf_ - specific enum size for commsType (for more compact structures in the future). Default construct lists items. BUG: possible incidental indexing in UIPstream::read(char*, std::streamsize) - raw reading had been split into beginRawRead(), readRaw(). However, this could change the current input position (due to word boundary alignment), even if the expected count is zero. Make a no-op for count == 0. This mirrors UOPstream::write behaviour.
Showing
- src/OpenFOAM/db/IOstreams/Pstreams/IPstream.C 7 additions, 9 deletionssrc/OpenFOAM/db/IOstreams/Pstreams/IPstream.C
- src/OpenFOAM/db/IOstreams/Pstreams/IPstream.H 6 additions, 6 deletionssrc/OpenFOAM/db/IOstreams/Pstreams/IPstream.H
- src/OpenFOAM/db/IOstreams/Pstreams/OPstream.C 11 additions, 3 deletionssrc/OpenFOAM/db/IOstreams/Pstreams/OPstream.C
- src/OpenFOAM/db/IOstreams/Pstreams/OPstream.H 3 additions, 4 deletionssrc/OpenFOAM/db/IOstreams/Pstreams/OPstream.H
- src/OpenFOAM/db/IOstreams/Pstreams/Pstream.H 13 additions, 11 deletionssrc/OpenFOAM/db/IOstreams/Pstreams/Pstream.H
- src/OpenFOAM/db/IOstreams/Pstreams/PstreamBuffers.C 6 additions, 12 deletionssrc/OpenFOAM/db/IOstreams/Pstreams/PstreamBuffers.C
- src/OpenFOAM/db/IOstreams/Pstreams/PstreamBuffers.H 26 additions, 26 deletionssrc/OpenFOAM/db/IOstreams/Pstreams/PstreamBuffers.H
- src/OpenFOAM/db/IOstreams/Pstreams/UIPstream.C 43 additions, 28 deletionssrc/OpenFOAM/db/IOstreams/Pstreams/UIPstream.C
- src/OpenFOAM/db/IOstreams/Pstreams/UIPstream.H 16 additions, 16 deletionssrc/OpenFOAM/db/IOstreams/Pstreams/UIPstream.H
- src/OpenFOAM/db/IOstreams/Pstreams/UOPstream.C 58 additions, 44 deletionssrc/OpenFOAM/db/IOstreams/Pstreams/UOPstream.C
- src/OpenFOAM/db/IOstreams/Pstreams/UOPstream.H 15 additions, 14 deletionssrc/OpenFOAM/db/IOstreams/Pstreams/UOPstream.H
- src/OpenFOAM/db/IOstreams/Pstreams/UPstream.C 8 additions, 8 deletionssrc/OpenFOAM/db/IOstreams/Pstreams/UPstream.C
- src/OpenFOAM/db/IOstreams/Pstreams/UPstream.H 40 additions, 42 deletionssrc/OpenFOAM/db/IOstreams/Pstreams/UPstream.H
- src/OpenFOAM/db/IOstreams/Pstreams/UPstreamCommsStruct.C 4 additions, 4 deletionssrc/OpenFOAM/db/IOstreams/Pstreams/UPstreamCommsStruct.C
- src/Pstream/dummy/UIPread.C 9 additions, 10 deletionssrc/Pstream/dummy/UIPread.C
- src/Pstream/mpi/UIPread.C 41 additions, 46 deletionssrc/Pstream/mpi/UIPread.C
- src/Pstream/mpi/UOPwrite.C 7 additions, 7 deletionssrc/Pstream/mpi/UOPwrite.C
Please register or sign in to comment