STYLE: manage dictionary inputMode directly within entry class
- The logic for switching input-mode was previously completely encapsulated within the #inputMode directive, but without any programming equivalent. Furthermore, the encapsulation in inputMode made the logic less clear in other places. Exposing the inputMode as an enum with direct access from entry simplifies things a fair bit. - eliminate one level of else/if nesting in entryIO.C for clearer logic - for dictionary function entries, simply use addNamedToMemberFunctionSelectionTable() and avoid defining a type() as a static. For most function entries the information is only used to get a name for the selection table lookup anyhow.
Showing
- applications/test/dictionary/testDict 2 additions, 1 deletionapplications/test/dictionary/testDict
- src/OpenFOAM/Make/files 1 addition, 1 deletionsrc/OpenFOAM/Make/files
- src/OpenFOAM/db/dictionary/dictionaryIO.C 3 additions, 4 deletionssrc/OpenFOAM/db/dictionary/dictionaryIO.C
- src/OpenFOAM/db/dictionary/entry/entry.C 11 additions, 0 deletionssrc/OpenFOAM/db/dictionary/entry/entry.C
- src/OpenFOAM/db/dictionary/entry/entry.H 31 additions, 1 deletionsrc/OpenFOAM/db/dictionary/entry/entry.H
- src/OpenFOAM/db/dictionary/entry/entryIO.C 183 additions, 157 deletionssrc/OpenFOAM/db/dictionary/entry/entryIO.C
- src/OpenFOAM/db/dictionary/functionEntries/calcEntry/calcEntry.C 6 additions, 6 deletions...nFOAM/db/dictionary/functionEntries/calcEntry/calcEntry.C
- src/OpenFOAM/db/dictionary/functionEntries/calcEntry/calcEntry.H 9 additions, 25 deletions...nFOAM/db/dictionary/functionEntries/calcEntry/calcEntry.H
- src/OpenFOAM/db/dictionary/functionEntries/codeStream/codeStream.C 7 additions, 6 deletions...OAM/db/dictionary/functionEntries/codeStream/codeStream.C
- src/OpenFOAM/db/dictionary/functionEntries/codeStream/codeStream.H 6 additions, 8 deletions...OAM/db/dictionary/functionEntries/codeStream/codeStream.H
- src/OpenFOAM/db/dictionary/functionEntries/functionEntry/functionEntry.H 8 additions, 8 deletions.../dictionary/functionEntries/functionEntry/functionEntry.H
- src/OpenFOAM/db/dictionary/functionEntries/includeEntry/includeEntry.C 26 additions, 44 deletions...db/dictionary/functionEntries/includeEntry/includeEntry.C
- src/OpenFOAM/db/dictionary/functionEntries/includeEntry/includeEntry.H 10 additions, 22 deletions...db/dictionary/functionEntries/includeEntry/includeEntry.H
- src/OpenFOAM/db/dictionary/functionEntries/includeEtcEntry/includeEtcEntry.C 16 additions, 31 deletions...tionary/functionEntries/includeEtcEntry/includeEtcEntry.C
- src/OpenFOAM/db/dictionary/functionEntries/includeEtcEntry/includeEtcEntry.H 8 additions, 24 deletions...tionary/functionEntries/includeEtcEntry/includeEtcEntry.H
- src/OpenFOAM/db/dictionary/functionEntries/includeFuncEntry/includeFuncEntry.C 3 additions, 4 deletions...onary/functionEntries/includeFuncEntry/includeFuncEntry.C
- src/OpenFOAM/db/dictionary/functionEntries/includeFuncEntry/includeFuncEntry.H 2 additions, 9 deletions...onary/functionEntries/includeFuncEntry/includeFuncEntry.H
- src/OpenFOAM/db/dictionary/functionEntries/includeIfPresentEntry/includeIfPresentEntry.C 8 additions, 15 deletions...tionEntries/includeIfPresentEntry/includeIfPresentEntry.C
- src/OpenFOAM/db/dictionary/functionEntries/includeIfPresentEntry/includeIfPresentEntry.H 9 additions, 23 deletions...tionEntries/includeIfPresentEntry/includeIfPresentEntry.H
- src/OpenFOAM/db/dictionary/functionEntries/inputMode/inputMode.C 20 additions, 66 deletions...nFOAM/db/dictionary/functionEntries/inputMode/inputMode.C
Please register or sign in to comment