EulerDdtScheme: evaluate dimensioned internal field expressions rather than...

EulerDdtScheme: evaluate dimensioned internal field expressions rather than primitive field expressions Ensures dimension consistency and simplifies the expressions

EulerDdtScheme: evaluate dimensioned internal field expressions rather than...
EulerDdtScheme: evaluate dimensioned internal field expressions rather than primitive field expressions Ensures dimension consistency and simplifies the expressions
a3aa5892 · Henry Weller · 4c5052a3 · a3aa5892
Commit a3aa5892 authored 8 years ago by Henry Weller
--- a/src/finiteVolume/finiteVolume/ddtSchemes/EulerDdtScheme/EulerDdtScheme.C
+++ b/src/finiteVolume/finiteVolume/ddtSchemes/EulerDdtScheme/EulerDdtScheme.C
@@ -122,12 +122,10 @@ EulerDdtScheme<Type>::fvcDdt
            new GeometricField<Type, fvPatchField, volMesh>
            (
                ddtIOobject,
-                mesh(),
+                rDeltaT*
-                rDeltaT.dimensions()*vf.dimensions(),
-                rDeltaT.value()*
                (
-                    vf.primitiveField()
+                    vf()
-                  - vf.oldTime().primitiveField()*mesh().Vsc0()/mesh().Vsc()
+                  - vf.oldTime()()*mesh().Vsc0()/mesh().Vsc()
                ),
                rDeltaT.value()*
                (
@@ -174,12 +172,10 @@ EulerDdtScheme<Type>::fvcDdt
            new GeometricField<Type, fvPatchField, volMesh>
            (
                ddtIOobject,
-                mesh(),
+                rDeltaT*rho*
-                rDeltaT.dimensions()*rho.dimensions()*vf.dimensions(),
-                rDeltaT.value()*rho.value()*
                (
-                    vf.primitiveField()
+                    vf()
-                  - vf.oldTime().primitiveField()*mesh().Vsc0()/mesh().Vsc()
+                  - vf.oldTime()()*mesh().Vsc0()/mesh().Vsc()
                ),
                rDeltaT.value()*rho.value()*
                (
@@ -226,13 +222,11 @@ EulerDdtScheme<Type>::fvcDdt
            new GeometricField<Type, fvPatchField, volMesh>
            (
                ddtIOobject,
-                mesh(),
+                rDeltaT*
-                rDeltaT.dimensions()*rho.dimensions()*vf.dimensions(),
-                rDeltaT.value()*
                (
-                    rho.primitiveField()*vf.primitiveField()
+                    rho()*vf()
-                  - rho.oldTime().primitiveField()
+                  - rho.oldTime()()
-                   *vf.oldTime().primitiveField()*mesh().Vsc0()/mesh().Vsc()
+                   *vf.oldTime()()*mesh().Vsc0()/mesh().Vsc()
                ),
                rDeltaT.value()*
                (
@@ -282,18 +276,15 @@ EulerDdtScheme<Type>::fvcDdt
            new GeometricField<Type, fvPatchField, volMesh>
            (
                ddtIOobject,
-                mesh(),
-                rDeltaT.dimensions()
-               *alpha.dimensions()*rho.dimensions()*vf.dimensions(),
                rDeltaT.value()*
                (
-                    alpha.primitiveField()
+                    alpha()
-                   *rho.primitiveField()
+                   *rho()
-                   *vf.primitiveField()
+                   *vf()
-                  - alpha.oldTime().primitiveField()
+                  - alpha.oldTime()()
-                   *rho.oldTime().primitiveField()
+                   *rho.oldTime()()
-                   *vf.oldTime().primitiveField()*mesh().Vsc0()/mesh().Vsc()
+                   *vf.oldTime()()*mesh().Vsc0()/mesh().Vsc()
                ),
                rDeltaT.value()*
                (