ENH: improve consistency of fileName handling windows/non-windows (#2057)
- wrap command-line retrieval of fileName with an implicit validate. Instead of this: fileName input(args[1]); fileName other(args["someopt"]); Now use this: auto input = args.get<fileName>(1); auto other = args.get<fileName>("someopt"); which adds a fileName::validate on the inputs Because of how it is implemented, it will automatically also apply to argList getOrDefault<fileName>, readIfPresent<fileName> etc. - adjust fileName::validate and clean to handle backslash conversion. This makes it easier to ensure that path names arising from MS-Windows are consistently handled internally. - dictionarySearch: now check for initial '/' directly instead of relying on fileName isAbsolute(), which now does more things BREAKING: remove fileName::clean() const method - relying on const/non-const to control the behaviour (inplace change or return a copy) is too fragile and the const version was almost never used. Replace: fileName sanitized = constPath.clean(); With: fileName sanitized(constPath); sanitized.clean()); STYLE: test empty() instead of comparing with fileName::null
Showing
- applications/test/List3/Test-List3.C 3 additions, 3 deletionsapplications/test/List3/Test-List3.C
- applications/test/PackedList/Test-PackedList.C 3 additions, 2 deletionsapplications/test/PackedList/Test-PackedList.C
- applications/test/checkDecomposePar/Test-checkDecomposePar.C 2 additions, 3 deletionsapplications/test/checkDecomposePar/Test-checkDecomposePar.C
- applications/test/codeStream/Test-codeStream.C 3 additions, 2 deletionsapplications/test/codeStream/Test-codeStream.C
- applications/test/coordinateSystem/Test-coordinateSystem.C 3 additions, 3 deletionsapplications/test/coordinateSystem/Test-coordinateSystem.C
- applications/test/copyFile/Test-copyFile.C 3 additions, 3 deletionsapplications/test/copyFile/Test-copyFile.C
- applications/test/decomposedBlockData/Test-decomposedBlockData.C 2 additions, 1 deletion...tions/test/decomposedBlockData/Test-decomposedBlockData.C
- applications/test/dictionary/Test-dictionary.C 3 additions, 2 deletionsapplications/test/dictionary/Test-dictionary.C
- applications/test/dictionaryCopy/Test-dictionaryCopy.C 1 addition, 1 deletionapplications/test/dictionaryCopy/Test-dictionaryCopy.C
- applications/test/dictionaryTokens/Test-dictionaryTokens.C 2 additions, 2 deletionsapplications/test/dictionaryTokens/Test-dictionaryTokens.C
- applications/test/dynamicLibrary/Test-dynamicLibrary.C 2 additions, 2 deletionsapplications/test/dynamicLibrary/Test-dynamicLibrary.C
- applications/test/exprEntry/Test-exprEntry.C 2 additions, 2 deletionsapplications/test/exprEntry/Test-exprEntry.C
- applications/test/fileName/Test-fileName.C 2 additions, 2 deletionsapplications/test/fileName/Test-fileName.C
- applications/test/fileNameClean/Test-fileNameClean.C 12 additions, 6 deletionsapplications/test/fileNameClean/Test-fileNameClean.C
- applications/test/fstreamPointer/Test-fstreamPointer.C 2 additions, 2 deletionsapplications/test/fstreamPointer/Test-fstreamPointer.C
- applications/test/mvBak/Test-mvBak.C 3 additions, 2 deletionsapplications/test/mvBak/Test-mvBak.C
- applications/test/plotFunction1/Test-plotFunction1.C 2 additions, 2 deletionsapplications/test/plotFunction1/Test-plotFunction1.C
- applications/test/regex1/Test-regex1.C 1 addition, 1 deletionapplications/test/regex1/Test-regex1.C
- applications/test/spline/Test-spline.C 3 additions, 3 deletionsapplications/test/spline/Test-spline.C
- applications/test/surfaceIntersection/Test-surfaceIntersection.C 3 additions, 3 deletions...tions/test/surfaceIntersection/Test-surfaceIntersection.C
Please register or sign in to comment