1. 02 May, 2016 1 commit
    • Henry Weller's avatar
      functionObjects: Moved into the functionObjects namespace and rationalized and... · 0534a225
      Henry Weller authored
      functionObjects: Moved into the functionObjects namespace and rationalized and simplified failable construction
      Rather than requiring each functionObject to handle failed construction
      internally (using the active_ flag) the static member function "viable"
      is provided which returns true if construction of the functionObject is
      likely to be successful.  Failed construction is then handled by the
      wrapper-class which constructs the functionObject,
      e.g. "OutputFilterFunctionObject".
  2. 01 May, 2016 4 commits
  3. 30 Apr, 2016 7 commits
    • Henry Weller's avatar
      tutorials: Renamed .org -> .orig · 1b342313
      Henry Weller authored
      See http://www.openfoam.org/mantisbt/view.php?id=2076
        - .org is the file extension for emacs org-mode as well
        - .orig is more to the point (.org isn't always recognized as "original")
        - .original is too long, although more consistent with the convention
          of source code file naming
      Update script contributed by Bruno Santos
    • Henry Weller's avatar
      Updated headers · 81f31acb
      Henry Weller authored
    • Henry Weller's avatar
      GeometricField: Renamed internalField() -> primitiveField() and... · 3c053c2f
      Henry Weller authored
      GeometricField: Renamed internalField() -> primitiveField() and dimensionedInternalField() -> internalField()
      These new names are more consistent and logical because:
          Provides low-level access to the Field<Type> (primitive field)
          without dimension or mesh-consistency checking.  This should only be
          used in the low-level functions where dimensional consistency is
          ensured by careful programming and computational efficiency is
          Provides access to the DimensionedField<Type, GeoMesh> of values on
          the internal mesh-type for which the GeometricField is defined and
          supports dimension and checking and mesh-consistency checking.
    • Henry Weller's avatar
      GeometricField::dimensionedInteralFieldRef() -> GeometricField::ref() · ccd958a8
      Henry Weller authored
      In order to simplify expressions involving dimensioned internal field it
      is preferable to use a simpler access convention.  Given that
      GeometricField is derived from DimensionedField it is simply a matter of
      de-referencing this underlying type unlike the boundary field which is
      peripheral information.  For consistency with the new convention in
      "tmp"  "dimensionedInteralFieldRef()" has been renamed "ref()".
    • Henry Weller's avatar
      CrankNicolsonDdtScheme: Use the new GeometricField constructor from... · 68b69a25
      Henry Weller authored
      CrankNicolsonDdtScheme: Use the new GeometricField constructor from DimensionedField and boundary FieldField
    • Henry Weller's avatar
      GeometricField::internalField() -> GeometricField::internalFieldRef() · 5df2b964
      Henry Weller authored
      Non-const access to the internal field now obtained from a specifically
      named access function consistent with the new names for non-canst access
      to the boundary field boundaryFieldRef() and dimensioned internal field
      See also commit 22f4ad32
    • Henry Weller's avatar
      functionObjectFile: Separated into functionObjectFile and functionObjectFiles · 67e2d028
      Henry Weller authored
      functionObjectFile provides basic directory, file and formatting functions
      functionObjectFiles provides multi-file cache
  4. 29 Apr, 2016 3 commits
  5. 28 Apr, 2016 4 commits
  6. 27 Apr, 2016 4 commits
  7. 26 Apr, 2016 7 commits
  8. 25 Apr, 2016 4 commits
    • Henry Weller's avatar
      wmake/rules/linux.*Icc: Remove -xHost option which causes... · 4107d312
      Henry Weller authored
      wmake/rules/linux.*Icc: Remove -xHost option which causes surfaceFeatureExtract to fail for some cases
    • Henry Weller's avatar
      Completed boundaryField() -> boundaryFieldRef() · 22f4ad32
      Henry Weller authored
      Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1938
      Because C++ does not support overloading based on the return-type there
      is a problem defining both const and non-const member functions which
      are resolved based on the const-ness of the object for which they are
      called rather than the intent of the programmer declared via the
      const-ness of the returned type.  The issue for the "boundaryField()"
      member function is that the non-const version increments the
      event-counter and checks the state of the stored old-time fields in case
      the returned value is altered whereas the const version has no
      side-effects and simply returns the reference.  If the the non-const
      function is called within the patch-loop the event-counter may overflow.
      To resolve this it in necessary to avoid calling the non-const form of
      "boundaryField()" if the results is not altered and cache the reference
      outside the patch-loop when mutation of the patch fields is needed.
      The most straight forward way of resolving this problem is to name the
      const and non-const forms of the member functions differently e.g. the
      non-const form could be named:
      Given that in C++ a reference is non-const unless specified as const:
      "T&" vs "const T&" the logical convention would be
      and given that the const form which is more commonly used is it could
      simply be named "boundaryField()" then the logical convention is
          GeometricBoundaryField& boundaryFieldRef();
          inline const GeometricBoundaryField& boundaryField() const;
      This is also consistent with the new "tmp" class for which non-const
      access to the stored object is obtained using the ".ref()" member function.
      This new convention for non-const access to the components of
      GeometricField will be applied to "dimensionedInternalField()" and "internalField()" in the
      future, i.e. "dimensionedInternalFieldRef()" and "internalFieldRef()".
    • Henry Weller's avatar
    • Henry Weller's avatar
  9. 24 Apr, 2016 2 commits
  10. 23 Apr, 2016 4 commits
    • Henry Weller's avatar
      Updated header · a0e86416
      Henry Weller authored
    • Henry Weller's avatar
      boundaryField() -> boundaryFieldRef() · d8f8498c
      Henry Weller authored
    • Henry Weller's avatar
      boundaryField() -> boundaryFieldRef() · 7c12f774
      Henry Weller authored
    • Henry Weller's avatar
      GeometricField: New non-const access function boundaryFieldRef() · 45f73bf6
      Henry Weller authored
      There is a need to specify const or non-const access to a non-const
      object which is not currently possible with the "boundaryField()" access
      function the const-ness of the return of which is defined by the
      const-ness of the object for which it is called.  For consistency with
      the latest "tmp" storage class in which non-const access is obtained
      with the "ref()" function it is proposed to replace the non-const form
      of "boundaryField()" with "boundaryFieldRef()".
      Thanks to Mattijs Janssens for starting the process of migration to
      "boundaryFieldRef()" and providing a patch for the OpenFOAM and
      finiteVolume libraries.