- Nov 21, 2018
-
-
Mark OLESEN authored
- Catch any leading option (the incorrect location). - Catch initialization error for cleaner result.
-
- Oct 19, 2018
-
-
Mark OLESEN authored
-
- Jul 31, 2018
-
-
Mark OLESEN authored
General: * -roots, -hostRoots, -fileHandler Specific: * -to <coordinateSystem> -from <coordinateSystem> - Display -help-compat when compatibility or ignored options are available STYLE: capitalization of options text
-
- Oct 05, 2018
-
-
Mark OLESEN authored
- instead of dict.lookup(name) >> val; can use dict.readEntry(name, val); for checking of input token sizes. This helps catch certain types of input errors: { key1 ; // <- Missing value key2 1234 // <- Missing ';' terminator key3 val; } STYLE: readIfPresent() instead of 'if found ...' in a few more places.
-
- Apr 24, 2018
-
-
Mark OLESEN authored
- generalize some of the library extensions (.so vs .dylib). Provide as wmake 'sysFunctions' - added note about unsupported/incomplete system support - centralize detection of ThirdParty packages into wmake/ subdirectory by providing a series of scripts in the spirit of GNU autoconfig. For example, have_boost, have_readline, have_scotch, ... Each of the `have_<package>` scripts will generally provide the following type of functions: have_<package> # detection no_<package> # reset echo_<package> # echoing and the following type of variables: HAVE_<package> # unset or 'true' <package>_ARCH_PATH # root for <package> <package>_INC_DIR # include directory for <package> <package>_LIB_DIR # library directory for <package> This simplifies the calling scripts: if have_metis then wmake metisDecomp fi As well as reducing clutter in the corresponding Make/options: EXE_INC = \ -I$(METIS_INC_DIR) \ -I../decompositionMethods/lnInclude LIB_LIBS = \ -L$(METIS_LIB_DIR) -lmetis Any additional modifications (platform-specific or for an external build system) can now be made centrally.
-
- Mar 28, 2018
-
-
Andrew Heather authored
-
- Mar 16, 2018
-
-
Mark OLESEN authored
- when constructing dimensioned fields that are to be zero-initialized, it is preferrable to use a form such as dimensionedScalar(dims, Zero) dimensionedVector(dims, Zero) rather than dimensionedScalar("0", dims, 0) dimensionedVector("zero", dims, vector::zero) This reduces clutter and also avoids any suggestion that the name of the dimensioned quantity has any influence on the field's name. An even shorter version is possible. Eg, dimensionedScalar(dims) but reduces the clarity of meaning. - NB: UniformDimensionedField is an exception to these style changes since it does use the name of the dimensioned type (instead of the regIOobject).
-
- Feb 22, 2018
-
-
Mark OLESEN authored
- the wordHashSet typedef is always available when HashSet has been included. - use default HashTable key (word) instead of explicitly mentioning it
-
- Jan 08, 2018
-
-
Mark OLESEN authored
- use succincter method names that more closely resemble dictionary and HashTable method names. This improves method name consistency between classes and also requires less typing effort: args.found(optName) vs. args.optionFound(optName) args.readIfPresent(..) vs. args.optionReadIfPresent(..) ... args.opt<scalar>(optName) vs. args.optionRead<scalar>(optName) args.read<scalar>(index) vs. args.argRead<scalar>(index) - the older method names forms have been retained for code compatibility, but are now deprecated
-
- Nov 22, 2017
-
-
Mark OLESEN authored
-
- Jul 22, 2017
-
-
Mark OLESEN authored
-
Mark OLESEN authored
-
- Jul 03, 2017
-
-
Mark OLESEN authored
-
- May 19, 2017
-
-
Andrew Heather authored
-
- May 16, 2017
-
-
Mark OLESEN authored
- ensure that the string-related classes have consistently similar matching methods. Use operator()(const std::string) as an entry point for the match() method, which makes it easier to use for filters and predicates. In some cases this will also permit using a HashSet as a match predicate. regExp ==== - the set method now returns a bool to signal that the requested pattern was compiled. wordRe ==== - have separate constructors with the compilation option (was previously a default parameter). This leaves the single parameter constructor explicit, but the two parameter version is now non-explicit, which makes it easier to use when building lists. - renamed compile-option from REGEX (to REGEXP) for consistency with with the <regex.h>, <regex> header names etc. wordRes ==== - renamed from wordReListMatcher -> wordRes. For reduced typing and since it behaves as an entity only slightly related to its underlying list nature. - Provide old name as typedef and include for code transition. - pass through some list methods into wordRes hashedWordList ==== - hashedWordList[const word& name] now returns a -1 if the name is is not found in the list of indices. That has been a pending change ever since hashedWordList was generalized out of speciesTable (Oct-2010). - add operator()(const word& name) for easy use as a predicate STYLE: adjust parameter names in stringListOps - reflect if the parameter is being used as a primary matcher, or the matcher will be derived from the parameter. For example, (const char* re), which first creates a regExp versus (const regExp& matcher) which is used directly.
-
- Jun 08, 2017
-
-
Andrew Heather authored
-
- Feb 23, 2017
-
-
Mark Olesen authored
STYLE: improve consistency in Allwclean scripts
-
- Jan 26, 2017
-
-
Henry Weller authored
-
- Nov 13, 2016
-
-
Henry Weller authored
'set -x' should be used for debugging. Added command printing into wmake and Allwmake as a replacement for 'set -x' to log current target.
-
- Jul 18, 2016
-
-
Mark Olesen authored
The normal library system() command uses 'fork', which causes problems on IB+OPENMPI. STYLE: add Foam:: qualifier to system calls to make them easier to spot.
-
- Jun 24, 2016
-
-
Henry Weller authored
Patch contributed by Mattijs Janssens
-
- Jun 17, 2016
-
-
Henry Weller authored
-
- Apr 29, 2016
-
-
Andrew Heather authored
-
- Apr 04, 2016
-
-
Henry Weller authored
Patch contributed by Bruno Santos Resolved bug-report http://www.openfoam.org/mantisbt/view.php?id=2042
-
- Mar 22, 2016
-
-
Henry Weller authored
-
- Jun 27, 2016
-
-
Andrew Heather authored
-
- Feb 15, 2016
-
-
Henry Weller authored
-
- Feb 03, 2016
-
-
Henry Weller authored
and pre-construct constant strings and names Speeds-up parsing of DTAGS so that lookup of a name takes ~1s Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=982
-
- Jan 25, 2016
-
-
mattijs authored
Moved file path handling to regIOobject and made it type specific so now every object can have its own rules. Examples: - faceZones are now processor local (and don't search up anymore) - timeStampMaster is now no longer hardcoded inside IOdictionary (e.g. uniformDimensionedFields support it as well) - the distributedTriSurfaceMesh is properly processor-local; no need for fileModificationChecking manipulation.
-
- Jan 10, 2016
-
-
Henry Weller authored
-
- Dec 09, 2015
-
-
Andrew Heather authored
-
- Dec 01, 2015
-
-
Henry Weller authored
-
- Nov 29, 2015
-
-
mattijs authored
-
- Nov 27, 2015
-
-
Andrew Heather authored
-
- Nov 10, 2015
-
-
Henry Weller authored
Avoids the clutter and maintenance effort associated with providing the function signature string.
-
- Mar 24, 2015
-
-
Henry authored
Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1421
-
- Jan 21, 2015
-
-
Henry authored
The old separate incompressible and compressible libraries have been removed. Most of the commonly used RANS and LES models have been upgraded to the new framework but there are a few missing which will be added over the next few days, in particular the realizable k-epsilon model. Some of the less common incompressible RANS models have been introduced into the new library instantiated for incompressible flow only. If they prove to be generally useful they can be templated for compressible and multiphase application. The Spalart-Allmaras DDES and IDDES models have been thoroughly debugged, removing serious errors concerning the use of S rather than Omega. The compressible instances of the models have been augmented by a simple backward-compatible eddyDiffusivity model for thermal transport based on alphat and alphaEff. This will be replaced with a separate run-time selectable thermal transport model framework in a few weeks. For simplicity and ease of maintenance and further development the turbulent transport and wall modeling is based on nut/nuEff rather than mut/muEff for compressible models so that all forms of turbulence models can use the same wall-functions and other BCs. All turbulence model selection made in the constant/turbulenceProperties dictionary with RAS and LES as sub-dictionaries rather than in separate files which added huge complexity for multiphase. All tutorials have been updated so study the changes and update your own cases by comparison with similar cases provided. Sorry for the inconvenience in the break in backward-compatibility but this update to the turbulence modeling is an essential step in the future of OpenFOAM to allow more models to be added and maintained for a wider range of cases and physics. Over the next weeks and months more turbulence models will be added of single and multiphase flow, more additional sub-models and further development and testing of existing models. I hope this brings benefits to all OpenFOAM users. Henry G. Weller
-
- Dec 14, 2014
-
-
Henry authored
-
- Feb 24, 2014
-
-
andy authored
-
- Jan 30, 2014
-
-
Henry authored
-