GitLab

- this helps for trapping unguarded dictionary lookups.

to support multiphase solvers in which the phases have the same velocity field.

Avoids the clutter and maintenance effort associated with providing the
function signature string.

nuSgsUSpaldingWallFunction removed, now use nutUSpaldingWallFunction

nuSgsUSpaldingWallFunction removed, now use nutUSpaldingWallFunction

This reverts commit c5bea524.

This reverts commit b18f6cc1.

Now instead of looking up RASModel we can lookup turbulenceModel instead.

- thermalDissipation()
  corresponds to the energy lost due to viscous efffects and
  what exits the energy cascade via dissipation.

- thermalDissipationEff()
  corresponds to the energy lost due to effective viscous efffects.
  Everything that is lost from momentum. Thus essentially assumes
  turbulent equilibrium, but is what STAR-CD and Fluent seem to be using.
  Thus even if it's wrong, provide it anyhow.

- minor consistency update in comments

- added constructor dictionary(const dictionary*) that also handles NULL
  pointers and makes it convenient to construct from a possibly nonexistent
  sub-dictionary:
  eg,
      dictionary dict2(dict1.subDictPtr("someDict"));

- make some of the turbulence Coeffs sub-dictionary optional.
  Their contents are all 'lookupOrAddDefault' anyhow.

- in turbulentMixingLength BCs, skip namespace qualifier in template
  (eg, <RASModel> vs. <compressible::RASModel>)

- change comments from 'turbulenceProperties' to RASProperties/LESProperties

- consistency between compressible/incompressible - no separate file for
  'New' selector etc

- consistency in accessing the model coefficients.
  Use method coeffDict() for const access.
  Use protected data member coeffDict_ for read/write access.

- document model coefficients in etc/constant/RASProperties.
  Need the same for LESProperties before we can prune these from the
  tutorials.

This allows the constructions of applications which are independent of the particular
type of turbulence modelling.