Skip to content
Snippets Groups Projects

checkIndex always enabled for PackedList and bitSet

    • Closed Issue created by Kutalmış Berçin @kuti

    checkIndex function of OpenFOAM containers is usually wrapped by FULLDEBUG preprocessor directive for subscripting operator, e.g. UList . Yet for PackedList and bitSet subscripting, FULLDEBUG was commented out for testing purposes, and left as is. I wonder if they were forgotten?

    PackedList

    bitSet

        // Leave enabled during testing period (MAR-2018)
    // #ifdef FULLDEBUG
    checkIndex(i);
    // #endif
    Edited

      Child items

      0
      Show labels

      No child items are currently assigned. Use child items to break down this issue into smaller parts.

        Activity

        • Kutalmış Berçin changed title from Is checkIndex left enabled for PackedList and bitSet unlike for other containers to checkIndex might be forgotten enabled for PackedList and bitSet unlike for other containers

          changed title from Is checkIndex left enabled for PackedList and bitSet unlike for other containers to checkIndex might be forgotten enabled for PackedList and bitSet unlike for other containers

        • Kutalmış Berçin changed the description

          changed the description

        • Kutalmış Berçin
          Kutalmış Berçin @kuti ·
          Author Maintainer

          @Prashant

        • Mark OLESEN changed title from checkIndex might be forgotten enabled for PackedList and bitSet unlike for other containers to checkIndex always enabled for PackedList and bitSet

          changed title from checkIndex might be forgotten enabled for PackedList and bitSet unlike for other containers to checkIndex always enabled for PackedList and bitSet

        • Mark OLESEN
          Mark OLESEN @mark ·
          Maintainer

          Not fully forgotten - thanks to the reminder!

          After 2 releases, we can probably consider the "testing period" to be absolved and can relegate it to FULLDEBUG only.

          @Mattijs, @andy - add your votes

        • Mattijs Janssens
          Mattijs Janssens @Mattijs ·
          Maintainer

          Mattijs: vote to remove. Andy:vote to remove.

        • Mark OLESEN mentioned in commit 08a608302370c838c391c59c48d63268817ff49e

          mentioned in commit 08a608302370c838c391c59c48d63268817ff49e

        • Mark OLESEN closed

          closed

        Please register or sign in to reply