Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • openfoam openfoam
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 415
    • Issues 415
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Development
  • openfoamopenfoam
  • Issues
  • #1391
Closed
Open
Issue created Aug 02, 2019 by Mark OLESEN@markMaintainer

more expressive matrix method names

A problem was recently encountered by @philipc while porting some foam-extend code. In the OpenFOAM Matrix class, we use m() for rows and n() for cols, whereas foam-extend use the opposite naming. This obviously makes for some very difficult error-finding.

Since there is nothing intrinsically meaningful about m and n, I suggest that we use rows() and cols() instead (method names as per Eigen3) and mark m() and n() as deprecated. This would help identify these types of pitfalls in the future.

Votes please: @andy @kuti @philipc

Assignee
Assign to
Time tracking