Skip to content

Enthalpy departure function in incompressiblePerfectGas

I just noticed an inconsistency in the departure functions for the species EOS incompressiblePerfectGas.

Currently, the enthalpy departure function returns 0 while the entropy departure function returns this->R(): https://develop.openfoam.com/Development/openfoam/blob/develop/src/thermophysicalModels/specie/equationOfState/incompressiblePerfectGas/incompressiblePerfectGasI.H#L95

The S departure function was changed in this commit from returning 0 to return this->R(): 8170f2ad

This seems to have followed a commit from the foundation version, where both H and S departure functions were changed: https://github.com/OpenFOAM/OpenFOAM-dev/commit/f9971f80d72a5318cdc81120a925ab9817b3ec62#diff-eba45488ddda848e509a02d99a262422

But only the change of S was adopted, while H still returns 0. Is this intentional? I don't know which of the two versions is the correct one.