Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • openfoam openfoam
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 383
    • Issues 383
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 12
    • Merge requests 12
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Development
  • openfoamopenfoam
  • Issues
  • #1614

Closed
Open
Created Feb 28, 2020 by Thorsten Zirwes@g3

Enthalpy departure function in incompressiblePerfectGas

I just noticed an inconsistency in the departure functions for the species EOS incompressiblePerfectGas.

Currently, the enthalpy departure function returns 0 while the entropy departure function returns this->R(): https://develop.openfoam.com/Development/openfoam/blob/develop/src/thermophysicalModels/specie/equationOfState/incompressiblePerfectGas/incompressiblePerfectGasI.H#L95

The S departure function was changed in this commit from returning 0 to return this->R(): 8170f2ad

This seems to have followed a commit from the foundation version, where both H and S departure functions were changed: https://github.com/OpenFOAM/OpenFOAM-dev/commit/f9971f80d72a5318cdc81120a925ab9817b3ec62#diff-eba45488ddda848e509a02d99a262422

But only the change of S was adopted, while H still returns 0. Is this intentional? I don't know which of the two versions is the correct one.

Assignee
Assign to
Time tracking