faMatrix residual changes source?

by inspection (noticed while examining #1834 (closed)). The faMatrix::residual has this code:

tmp<Field<Type>> tres(source_);
Field<Type>& res = tres().ref();

which implies that calculating the residual affects the source vector.

Probably should be

tmp<Field<Type>> tres(new Field<Type>>(source_);
Field<Type>& res = tres().ref();

@andy

I have cross-posted this bug to openfoam-extend project (ticket #54) as it is in their code too. It was confirmed as bug by Hrv.

Very thorough followup, don't see that quite so often. Thanks!

mentioned in commit 973e2d4e

closed

Fixed in develop. Not really used, so left as-is in maintenance branches.