primitiveMesh::edgeFaces produces different results whether using cached or uncached data

Summary

primitiveMesh::edgeFaces comes in two versions:

• calculate edgeFaces for all edges of the mesh. This is ok.
• calculate edgeFaces only for a single edge (i.e. uncached). This produces false positives for faces with difficult edge connectivity.

Steps to reproduce

Run attached test program on motorBike tutorial.

What is the current bug behaviour?

For some edges the uncached version returns 3 faces whereas the proper one returns 2 faces.

Relevant logs and/or images

Environment information

• OpenFOAM version : v2012

Possible fixes

We're looping through pointFaces to see the common faces. However we do not check the edge is an edge (i.e. using consecutive vertices) on all the faces.