Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • openfoam openfoam
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 379
    • Issues 379
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Development
  • openfoamopenfoam
  • Issues
  • #2060

Closed
Open
Created Apr 12, 2021 by Hunor Csala@hcsala

Wrong initialization of stepFraction_ in particle.C

Summary

Location: https://develop.openfoam.com/Development/openfoam/-/blob/develop/src/lagrangian/basic/particle/particle.C#L530 and lines 551, 584 as well.

In v2012, in the particle.C code, a variable called stepFraction_ is initialized to be 1, while in all previous versions (v2006 or earlier) it was initialized to be 0. The definition of stepFraction is not changed, therefore, I believe the correct initialization is 0.

Environment information

  • OpenFOAM version : v2012

Possible fixes

Change lines 530 (https://develop.openfoam.com/Development/openfoam/-/blob/develop/src/lagrangian/basic/particle/particle.C#L530), 551, 584 to: stepFraction_(0.0),. This is how it was in OpenFOAM v2006 and previous versions.

Edited Apr 13, 2021 by Hunor Csala
Assignee
Assign to
Time tracking