apply RIST improvements

Various improvements noted in EP1829 that warrant integration, but need proper code refactoring and integration.

@Taka, @Azami @Mattijs

assigned to @mark

changed the description

As discussed, this changeset will also lend itself nicely to inserting into scatter (the OpenFOAM term scatter is actually a broadcast). Apart from the obvious place as Foam::scatter, it could also be useful for streaming aggregate values.

Eg, (from src/lumpedPointMotion/state/lumpedPointState.C).

// Scatter master data using communication scheme

const List<Pstream::commsStruct>& comms =
(
    (Pstream::nProcs() < Pstream::nProcsSimpleSum)
   ? Pstream::linearCommunication()
  : Pstream::treeCommunication()
);

// Get my communication order
const Pstream::commsStruct& myComm = comms[Pstream::myProcNo()];

// Receive from up
if (myComm.above() != -1)
{
    IPstream fromAbove
    (
        UPstream::commsTypes::scheduled,
        myComm.above(),
        0,
        Pstream::msgType(),
        Pstream::worldComm
    );

    fromAbove >> points_ >> angles_ >> degrees_;
}

// Send to downstairs neighbours
forAllReverse(myComm.below(), belowI)
{
    OPstream toBelow
    (
        UPstream::commsTypes::scheduled,
        myComm.below()[belowI],
        0,
        Pstream::msgType(),
        Pstream::worldComm
    );

    toBelow << points_ << angles_ << degrees_;
}

rotationPtr_.reset(nullptr);

// MPI barrier
Pstream::scatter(ok);

I think this will be replaceable with this:

// Scatter master data
if (Pstream::master())
{
    OPBstream toAll(Pstream::masterNo());
    toAll << points_ << angles_ << degrees_;
}
else
{
    IPBstream fromMaster(Pstream::masterNo());
    fromMaster >> points_ >> angles_ >> degrees_;
}

rotationPtr_.reset(nullptr);

@Henning86 and @johan_roenby

Since some of these changes will positively affect isoAdvection, I've tagged you as well so that you will get notification when things get pushed.

mentioned in commit ff0043a1

mentioned in commit 0484ac1d

mentioned in commit eeeba129

mentioned in merge request !528 (merged)

mentioned in commit 20202882

mentioned in commit bed3deed

mentioned in commit 4de1d212

mentioned in commit de61c9d6

mentioned in commit 7bf1ea16

mentioned in commit 4a550ba0

mentioned in commit 3fdcdf60

mentioned in commit a9cdaa1b

mentioned in commit ff4998d3

mentioned in commit 2b54d861

mentioned in commit 8478595a

closed

mentioned in commit 10cf9cb3

mentioned in commit 18e0d7e4

mentioned in commit a27c8560