Skip to content

questionable code in point/face/cell mappers

As an example, in the faceMapper constructor, the insertedFaces_ is initialized as true. This is set to false, if direct() and no maps. In the second branch, there are an additional check if there are any inserted faces with no owner. However, after lots of loops etc. the only effect will be to set insertedFaces_ = true again.

This is probably a good thing, since in insertedObjectLabels() there is a special short-cut handling for when there are no inserted faces. However, this shortcut can force the creation of the pointer and would trigger a FatalError on a subsequent call to calcAddressing().

@andy or @Mattijs for some input here.