Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • openfoam openfoam
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 423
    • Issues 423
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Development
  • openfoamopenfoam
  • Issues
  • #352
Closed
Open
Issue created Dec 18, 2016 by Mark OLESEN@markMaintainer

cleanup noFunctionObjects vs withFunctionObjects etc

potentialFoam is the only solver or application to use -withFunctionObjects, all others have an implicit -noFunctionObjects. This exception does make sense, but opens questions about the general handling of function-objects. There are a number of utilities (conversion, blockMesh, etc) without a time-loop and thus it doesn't make much sense to even provide a -noFunctionObjects option for them.

Propose adding a argList::noFunctionObjects() method - similar to the argList::noParallel() method - to remove the availability of the -noFunctionObjects option and adjust Time accordingly.

Currently:

functionObjects_
(
    *this,
    argList::validOptions.found("withFunctionObjects")
  ? args.optionFound("withFunctionObjects")
  : !args.optionFound("noFunctionObjects")
)

Proposed:

functionObjects_
(
    *this,
    argList::validOptions.found("withFunctionObjects")
  ? args.optionFound("withFunctionObjects")
  : argList::validOptions.found("noFunctionObjects")
  ? !args.optionFound("noFunctionObjects")
  : false
)

For potentialFoam it also doesn't make sense to provide the -noFunctionObjects option at all. It adds clutter and will always be ignored anyhow.

@andy @Mattijs @Prashant

Assignee
Assign to
Time tracking