surface sample writing using Ostream

These should largely be using OSstream or even std::ostream since the output target is normally a file etc.

added ~30 label

assigned to @mark

changed milestone to %v1712

@andy, @Mattijs : see any problems with having a dummy stdStream() implementation in the top-level Istream/Ostream? Eg,

std::ostream& Foam::Ostream::stdStream()
{
    NotImplemented;
    return reinterpret_cast<ostream&>(*this);
}

• Pro: can get at STL stream from things that are passed as Ostream.
• Con: Incorrectly using stdStream with a Pstream or ITstream becomes a run-time fatal rather than compile-time.

What exactly do you need OSstream functionality for on the Ostream level?

Why not upcast to OSstream& ? Will have the same effect (run-time failure)

That is part of the debate - where the restriction should occur.

Ostream is currently not bound to std IO. Wouldn't like to fit std IO hooks to the base level. If so we can make the same argument to fit MPI specific hooks (e.g. communicator) to the base level?

Hi @mark , is the ticket resolved considering the milestone v1712?

Considered resolved with all of the changes for surface writers (part of the runTimePostProcessing merge).

closed