COMP: 64 bit label compilation - further updates

Further compilation failure at

foamVtkLagrangianWriter.C:103:25: error: call of overloaded 'write(int)' is ambiguous

@mark

assigned to @mark and unassigned @Mattijs

Does vtk handle 64 bit integers or should they all be truncated to 32?

Maybe review d1023dd43abaf4af7e9908281daa2e0e83022067 as well.

I don't know if this has changed in the legacy VTK file format in the past year or so, but last time I checked this, vtktypeint64 is supported for datasets but not for the CELLS entry.

For more details, see the notes I wrote back then: https://github.com/wyldckat/wyldckat.github.io/wiki/OpenFOAM_VTK_FileFormat

By Bruno Santos on 2017-06-15T14:15:54 (imported from GitLab project)

@Mattijs : the fix looks correct.

As far as I know, the legacy format only really manages 32-bit int/float properly. Using legacy in combination with 64-bit labels should compile, but is quite dubious if we should actually support this.

For the xml formats, it can manage 32/64-bit int/float. At the moment, we flatten both float and double to 32-bit. This is consistent with the legacy treatment, saves space, and should be accurate enough for post-processing. With a minor level of effort, this could be made configurable (either as a static switch, or a formatter option). The integers are written as 'label' and should be 32/64-bit depending on the WM_LABEL_SIZE.

fixed via OpenFOAM-plus@5cb1dab8

closed