Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • openfoam openfoam
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 426
    • Issues 426
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Development
  • openfoamopenfoam
  • Issues
  • #563
Closed
Open
Issue created Aug 09, 2017 by Mark OLESEN@markMaintainer

markup for pstream token types is fragile

This seems to be the root of the issue I encountered while adding in dictionary macros. The additional MACRO enumeration value (placed immediately after WORD) means that the indices of the subsequent tokenType enumerations increase by one. This made DOUBLE_SCALAR receive a value of 9. In UOPstream::write(double) this enumeration value is written as a character, which unfortunately corresponds to Tab and thus gets swallowed as a whitespace character. After this, the receiving end hasn't much chance.

I think that we should be invoking writeToBuffer(char) directly instead of using things like write(char(token::DOUBLE_SCALAR)) - should be more reliable.

@Mattijs

Assignee
Assign to
Time tracking