BUG: Disallow advectionDiffusion method within advectionDiffusionCoeffs for wallDist

The example illustrates the recursive problem pitzDaily_wallDist_issue.tgz

wallDist
{
    method advectionDiffusion; //meshWave, advectionDiffusion, Poisson
    nRequired yes;
    advectionDiffusionCoeffs
    {
        method advectionDiffusion; //Disallow this!
    }
}

@Sergio @Mattijs

The advectionDiffusion method can use a 'predictor' Eq to improve convergence. In the advectionDiffusionCoeffs dictionary is where you must specified the method to use such as : advectionDiffusionCoeffs { method Poisson; epsilon 0.1; tolerance 1e-3; maxIter 10; }

Status changed to closed

Sergio, I agree with you.

The issue was raised to just add an error statement in code when user tries to specify advectionDiffusion as method within advectionDiffusionCoeffs.

You may close the issue if this is obvious.

Status changed to reopened

In v1812:

blockMesh && topoSet && refineMesh -overwrite -dict system/refineMeshDict && decomposePar && mpirun -np 4 potentialFoam -noFunctionObjects -initialiseUBCs -parallel run fine.

mpirun -np 4 applyBoundaryLayer -parallel -Cbl 0.5 >& log.applyBoundaryLayer produces: log.applyBoundaryLayer

1. replace

dict.optionalSubDict(type() + "Coeffs")

with

dict.subDict(type() + "Coeffs")

This will make sure that users will have a sub dictionary for the predictor so less likely to choose the advectionDiffusion for the predictor as well

2. if the solver tolerance on yWall is larger than the 'tolerance' for the loop in advectionDiffussionPatchDistMethod it might do zero iterations and loop all the way to "maxIter" since nothing has changed.

assigned to @Mattijs and unassigned @andy

mentioned in commit f9f0a25e712514dfea00fcfdf13ce0cede8b1e52

mentioned in commit 9a8b484d787fcae1385b0ad5f83d548df115f1d7

mentioned in commit 5d9f584f3373dc79cb9769e86bcfb8170e5ff3ee

With the following set of settings:

wallDist
{
    method advectionDiffusion; //meshWave, advectionDiffusion, Poisson
    nRequired yes;
    advectionDiffusionCoeffs
    {
        method advectionDiffusion; //Disallow this!
    }
}

mpirun -np 4 applyBoundaryLayer -parallel -Cbl 0.5 >& log.applyBoundaryLayer correctly throws FATAL ERROR: log.error

By changing the inner advectionDiffusionCoeffs entry as follows:

wallDist
{
    method advectionDiffusion; //meshWave, advectionDiffusion, Poisson
    nRequired yes;
    advectionDiffusionCoeffs
    {
        method meshWave;
    }
}

mpirun -np 4 applyBoundaryLayer -parallel -Cbl 0.5 >& log.applyBoundaryLayer produces: log.2

IMHO, the ticket can be closed @Prashant .

Thanks.

closed