re-reading broken on time control function

It seems that any functionObject with an executeControl or writeControl will not properly re-read for its managed functionObject when modified.

Need to change timeControl::read(const dictionary&) to include this. Eg,

writeControl_.read(dict);
executeControl_.read(dict);
readControls();

// Missing this:
foPtr_->read();

Versions affected: 1712, 1706, 1612

@andy @sbna

changed the description

Q: propagate return value from underlying functionObject?

return foPtr_->read();
// Or simply
return true;

Agreed - and would propagate the return value

By Andrew Heather on 2018-01-25T09:27:02 (imported from GitLab project)

closed via commit d1a20c9f4e30ac859cf84136194bdc343c2353bb

mentioned in commit d1a20c9f4e30ac859cf84136194bdc343c2353bb

mentioned in commit 5a0a9aae0ad1ec27bb3bf2c68f6212aff46fd60d

mentioned in commit 9c9de5c1b5203fd6450021e1603f7cac720b43e7

mentioned in commit 553e3f84

mentioned in commit be3eee6c

mentioned in commit eb5a9fff