isoAdvector : Wrong parameter read in fvSolution. vof2IsoTol is expected by the sources. isoFaceTol is used in all tutorials.

In the source file ./finiteVolume/fvMatrices/solvers/isoAdvection/isoAdvection/isoAdvection.C, the parameter vof2IsoTol is read in fvSolution dictionary. See line 83 :

78	    // Interpolation data
79	    ap_(mesh_.nPoints()),
80	
81	    // Tolerances and solution controls
82	    nAlphaBounds_(dict_.lookupOrDefault<label>("nAlphaBounds", 3)),
83	    vof2IsoTol_(dict_.lookupOrDefault<scalar>("vof2IsoTol", 1e-8)),
84	    surfCellTol_(dict_.lookupOrDefault<scalar>("surfCellTol", 1e-8)),
85	    gradAlphaBasedNormal_
86	    (
87	        dict_.lookupOrDefault<bool>("gradAlphaNormal", false)
88	    ),

However, in all tutorials in $FOAM_TUTORIALS/multiphase/interIsoFoam, the parameter "isoFaceTol" is specified in fvSolution files, instead of vof2IsoTol.

The consequence of this bug is that the parameter "isoFaceTol" specified in fvSolution of the tutorials cases is never used. The vof2IsoTol expected by the sources (instead of "isoFaceTol") is always taken at its default value, so 1.e-8.

The correction is simple :

• Either correct all tutorials and replace isoFaceTol by vof2IsoTol, and leave the sources unchanged
• Or correct the sources to replace vof2IsoTol by isoFaceTol, and leave the tutorials unchanged

Regards

Lionel GAMET

@mark @andy

My personal inclination would be for isoFaceTol, but would like input from @johan_roenby

Hi Mark

Hope you are well.

As a user of OpenFOAM, I have experienced the suffering every time the case syntax is changed. We should try to minimize this pain. Therefore I would go for changing the lookup in the isoAdvection constructor.

Basically what I did in isoAdvection.C here:

https://github.com/isoAdvector/isoAdvector/commit/137daa09db2b46acc2b356ed5dee3bd17cb68da0#diff-d8df7a76cd56c091ecd001cf4ebe2432

Best, Johan

Thanks - I'll make the change.

closed via commit 4decf99e6eb01db3391c1621ab23bfcb0b1df8b5

mentioned in commit 54c07b56d9bb48fdde2d2a6d53175d612b68d864

mentioned in commit c6a651cc

mentioned in commit 34a77695