Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • openfoam openfoam
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 418
    • Issues 418
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Development
  • openfoamopenfoam
  • Issues
  • #825
Closed
Open
Issue created May 10, 2018 by Kutalmış Berçin@kutiMaintainer

Style: Changing for loops and ints according to the Coding Style Guide

Hi,

With respect to https://openfoam.org/dev/coding-style-guide/ , assuming ESI-OpenFOAM applies the same, the two points might need to be corrected throughout the code:

-- for (int i=0; i<10; i++) ++ for (label i = 0; i < 10; i++)

-- int iter = 0; ++ label iter = 0;

Some examples of the style inconsistencies can be found in src/.../wallFunctions, e.g.:

https://develop.openfoam.com/Development/OpenFOAM-plus/blob/master/src/TurbulenceModels/turbulenceModels/derivedFvPatchFields/wallFunctions/fWallFunctions/fWallFunction/fWallFunctionFvPatchScalarField.C#L72

Additional typos from OpenFOAM.org issue tracker:

https://www.openfoam.com/documentation/cpp-guide/html/classFoam_1_1functionObjects_1_1forceCoeffs.html#details

-- type Type name: forces ++ type Type name: forceCoeffs

https://develop.openfoam.com/Development/OpenFOAM-plus/blob/master/tutorials/incompressible/pimpleDyMFoam/wingMotion/wingMotion2D_simpleFoam/0.orig/omega#L13

-- epsilon ++ omega

K

Edited May 16, 2018 by Kutalmış Berçin
Assignee
Assign to
Time tracking