"double" instead of "float"

The vtkSurfaceWriter places the "float" string in vtk files, where some versions of ParaView (specifically windows versions) require the "double" string to be present. As far as I can tell, all versions of ParaView work fine with the "double" string. I'm working on the master branch of OpenFOAM, commit 0770f9a384bb74492751c6b8068f2c01fac2c49f.

The following changes fix the problem:

diff --git a/src/sampling/sampledSurface/writers/vtk/vtkSurfaceWriter.C b/src/sampling/sampledSurface/writers/vtk/vtkSurfaceWriter.C index 14a2716..f24b0cf 100644 --- a/src/sampling/sampledSurface/writers/vtk/vtkSurfaceWriter.C +++ b/src/sampling/sampledSurface/writers/vtk/vtkSurfaceWriter.C @@ -96,7 +96,7 @@ namespace Foam const Field& values ) {

•    os  << "1 " << values.size() << " float" << nl;

•    os  << "1 " << values.size() << " double" << nl;
  
     forAll(values, elemI)
     {

@@ -125,7 +125,7 @@ namespace Foam const Field& values ) {

•    os  << "3 " << values.size() << " float" << nl;

•    os  << "3 " << values.size() << " double" << nl;
  
     for (const vector& v : values)
     {

@@ -143,7 +143,7 @@ namespace Foam const Field& values ) {

•    os  << "1 " << values.size() << " float" << nl;

•    os  << "1 " << values.size() << " double" << nl;
  
     for (const sphericalTensor& v : values)
     {

@@ -159,7 +159,7 @@ namespace Foam const Field& values ) {

•    os  << "6 " << values.size() << " float" << nl;

•    os  << "6 " << values.size() << " double" << nl;
  
     for (const symmTensor& v : values)
     {

@@ -179,7 +179,7 @@ namespace Foam const Field& values ) {

•    os  << "9 " << values.size() << " float" << nl;

•    os  << "9 " << values.size() << " double" << nl;
  
     for (const tensor& v : values)
     {

diff --git a/src/sampling/sampledSurface/writers/vtk/vtkSurfaceWriterTemplates.C b/src/sampling/sampledSurface/writers/vtk/vtkSurfaceWriterTemplates.C index ee7c129..ddcf499 100644 --- a/src/sampling/sampledSurface/writers/vtk/vtkSurfaceWriterTemplates.C +++ b/src/sampling/sampledSurface/writers/vtk/vtkSurfaceWriterTemplates.C @@ -35,7 +35,7 @@ void Foam::vtkSurfaceWriter::writeData const Field& values ) {

• os << "1 " << values.size() << " float" << nl;

• os << "1 " << values.size() << " double" << nl;

  forAll(values, elemI) {

assigned to @mark

Okay, I can go along with that and it should be no problem since we are writing in ASCII anyhow. However, could you please check if that is also the case for other VTK legacy output?

• sampling sets has the vtkSetWriter, which also uses float
• edgeMesh output in VTK as well
• foamToVTK with output in ASCII (This one is the most difficult to change)

@Prashant

@kvm - I hope it's okay if I slate this for the next release, rather than calling it a true bug for 1712?

mentioned in commit a89e2cdd4033fb2f4579cc874012c29720e6b75b

@mark That is fine.

By Karl Meredith on 2018-06-21T16:56:58 (imported from GitLab project)

closed