Skip to content
Snippets Groups Projects

Add unit test for IOobjectList robustness enhancement

There was no unit test in the repo to check for this issue, so I added a script and example file to run one. Test will currently fail on develop. Passes on feature-robuster-ioobjectlist-construction to verify #539 (closed) was fixed by !134 (merged).

Edited by Admin

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Admin changed the description

    changed the description

    By Pete Bachant on 2017-07-29T12:40:52 (imported from GitLab project)

  • The unit test is an ok idea, but I somehow think that there must be an easier way ... but don't know off-hand what it is. I just used your test case with a quickly added controlDict.

    Edited by Mark OLESEN
  • Author Maintainer

    I figured it would be better to reuse a tutorial case since those are implied to be valid, so if that case changes there won't be a need to copy/paste changes into the test. However, things would go bad if an Allrun script were added to the tutorial.

    By Pete Bachant on 2017-07-29T13:12:32 (imported from GitLab project)

  • If I run foamDictionary -expand constant/turbulenceProperties.template the results look more than a bit odd too. Might need yet another re-think about how these these are failing or should be failing.

  • Hi @petebachant - Thanks for the effort. I think the idea is good, but the .gitignore and Allrun etc for the unit test seems quite messy. I think we should drop this one.

  • Author Maintainer

    Fair enough. Let me know if there is any initiative to turn these test apps into an automated unit test suite.

    By Pete Bachant on 2017-08-09T11:02:22 (imported from GitLab project)

  • closed

    By Pete Bachant on 2017-08-09T11:02:23 (imported from GitLab project)

  • OK - some form of low-level unit tests would be indeed useful.

Please register or sign in to reply
Loading