ENH: Updated regionModels from internal development line

indentation

alpha field level

Why not affect the mass?

non-conservative?

This is used to only apply the Co number constraint where the film is present - other wise numerical noise can generate spurious results

By Andrew Heather on 2015-12-02T17:27:59 (imported from GitLab project)

?

By Andrew Heather on 2015-12-02T17:28:22 (imported from GitLab project)

Need to check with @Sergio - this was added to enable the pyrolysis and film to act simultaneously

By Andrew Heather on 2015-12-02T17:30:42 (imported from GitLab project)

Non-conservative? Which term ? This one:

• fvc::ddt(residualDeltaRho + deltaRho_, hs_)

• fvm::ddt(residualDeltaRho + deltaRho_, hs_)

This avoids 0 = 0 situation created when alpha = 0 and deltaRho = 0. At convergence they cancel.

My question was about alpha in general. alpha is clipped to be either 1 or 0 (if some height gets low?)

You add the source only where alpha=1. Where alpha=0 you do not apply the source term. Hence you're throwing away that term (which might be needed for conservation). So now you've moved an accumulation error (height low) into a conservation error.

Added 1 commit:

• 40a88a14 - ENH: Changing p_rgh BC and call to solidThermo in noPyrolysis.C

Added 196 commits:

• 40a88a14...180e69c6 - 194 commits from branch develop
• ea642d39 - Merge remote-tracking branch 'origin/develop' into feature-regionModels
• 1837ec57 - STYLE: sigFpe: use of FatalErrorInFunction

mentioned in commit c8a9165b53f6b64593202da580b83ead6746a147

Status changed to merged