Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • openfoam openfoam
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 426
    • Issues 426
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Development
  • openfoamopenfoam
  • Merge requests
  • !250

WIP: ENH: Reforms QRMatrix class

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Kutalmış Berçin requested to merge issue-1240 into develop Mar 27, 2019
  • Overview 1
  • Commits 1
  • Changes 3
  • If applied:

    • Fixes issue #1240
    • New Test-QRMatrix.C for 3 input scenarios
    • Class output verified via NumPy, aka LAPACAK routines
    • Improves header documentation
    • Corrects Doxygen parsing problems, i.e. //-
    • Aligns code style with the code style guide
    • Applicable to Foam::complex template
  • Verification: See QRMatrix_Verifications.pdf for NumPy comparisons.

  • Future work:

    • Refactoring is possible if new Matrix class functions applied
    • For few matrix elements, NumPy and OpenFOAM yielded few-decimal point differences
    • //Info<< "Mx - b:" << nl << (Mx - source) << endl; affects the subsequent program states despite encapsulation. Memory leak might be the reason, will be checked

@mark

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: issue-1240