Introduced changes required to make isoAdvector and interIsoFoam work with...

Introduced changes required to make isoAdvector and interIsoFoam work with morphing meshes: 1) In the alphaEqn.H U is made relative to mesh motion before the interface advection step, 2) in isoAdvection::advect() alpha must be multiplied by Vsc0()/Vsc(). Implementation tested and verified with 1) a spherical interface in a cubic domain with no flow, where the domain walls are squeezed together and 2) a spherical interfacee inside the sloshingCylinder, again with no flow, so the sphere should stay spherical, which it does.

changed milestone to %v1906

added feature label

closed

reopened

By Andrew Heather on 2019-05-10T15:03:02 (imported from GitLab project)

Is this patch still valid? - there are conflicts when attempting to merge into the develop branch

By Andrew Heather on 2019-05-10T15:06:21 (imported from GitLab project)

Yes, this is still valid.

The conflict is because alphaEqn.H was also altered by the bugfix-isoAdvectorSubCyclingOuterCorr branch which moved all the nOuterCorrectors stuff from alphaEqn.H to alphaEqnSubCycle.H:

OpenFOAM-plus@c5ea1389

There should be no real conflict here.

Basically the required alteration to alphaEqn.H is to replace:

---

// Updating alpha1
advector.advect();

---

with

---

// Temporarily making U relative to mesh motion
if (mesh.moving()) 
{
    U -= fvc::reconstruct(mesh.phi());
}

// Updating alpha1
advector.advect();

// Making U absolute again after advection step
if (mesh.moving())
{
    U += fvc::reconstruct(mesh.phi());
}

---

to make U relative to mesh motion during advection.

The file isoAdvection.C is also modified, but there should be no conflict here.

added 128 commits

• 543fee50...e569aee0 - 127 commits from branch develop
• 81722421 - Introduced changes required to make isoAdvector and interIsoFoam work with...

Compare with previous version

By Andrew Heather on 2019-06-13T20:33:58 (imported from GitLab project)

mentioned in commit 0e755648f629d0f1e053bb505bb6d54340a49faf

By Andrew Heather on 2019-06-13T20:35:21 (imported from GitLab project)

merged

By Andrew Heather on 2019-06-13T20:35:21 (imported from GitLab project)

mentioned in issue #1302 (closed)

By Andrew Heather on 2019-06-13T20:48:01 (imported from GitLab project)