Skip to content
Snippets Groups Projects

Feature lagrangian

Merged Mark OLESEN requested to merge feature-lagrangian into develop

Minor adjustments to static information attached to lagrangian parcels/particles. Fixes #108 (closed) (duplicate of http://www.openfoam.org/mantisbt/view.php?id=1990), #109 (closed), #110 (closed), #111 (closed).

Future reworking would require a better mechanism to also deal with dynamic information such as particle collisions etc.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Looks good

    • worth considering using a Tuple/pair when describing the particle property name and type? maintenance-wise it would be less error-prone than keeping two separate lists

    By Andrew Heather on 2016-05-03T08:29:41 (imported from GitLab project)

  • Author Maintainer

    A Tuple/Pair could help, but first need a general scheme that also handles multiphase reacting with n-phases and n-species etc. The auxiliary information would need to become non-static for this to be supported.

  • Would it need to be non-static? e.g. is it sufficient to simply declare the lists using List as in these changes etc (where size does not need to be known in advance?)

    By Andrew Heather on 2016-05-06T14:58:33 (imported from GitLab project)

  • Admin Target branch changed from master to develop

    Target branch changed from master to develop

    By Andrew Heather on 2016-05-12T11:19:00 (imported from GitLab project)

  • Mark OLESEN Reassigned to @mark

    Reassigned to @mark

  • Mark OLESEN Marked this merge request as a Work In Progress

    Marked this merge request as a Work In Progress

  • Mark OLESEN Added 507 commits:

    Added 507 commits:

    • 740138a1...78321389 - 506 commits from branch develop
    • 1fdaeb5f - ENH: add parcel property types (fixes #109 (closed))
  • Mark OLESEN Unmarked this merge request as a Work In Progress

    Unmarked this merge request as a Work In Progress

  • Admin mentioned in commit b39045f7b23729a481c78d35435505d8c347f686

    mentioned in commit b39045f7b23729a481c78d35435505d8c347f686

    By Andrew Heather on 2016-06-03T15:14:53 (imported from GitLab project)

  • Admin Status changed to merged

    Status changed to merged

    By Andrew Heather on 2016-06-03T15:14:54 (imported from GitLab project)

Please register or sign in to reply