Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • openfoam openfoam
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 425
    • Issues 425
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 8
    • Merge requests 8
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Development
  • openfoamopenfoam
  • Merge requests
  • !340

ENH: Improve polynomial equations and analytical eigendecompositions

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kutalmış Berçin requested to merge feature-analytic-eigen into develop Feb 12, 2020
  • Overview 4
  • Commits 4
  • Changes 83

Summary

Analytical eigendecomposition routines show irregular numerical instabilities particularly for cases wherein off-diagonal elements of a tensor involve noise. The issue revealed to be caused by the polynomialEqn containers, particularly cubicEqn.

In addition, the analytical eigendecomposition routines seem to be mathematically inconsistent since tensors are not allowed to return complex types, which is nevertheless the norm for asymmetric matrices.

Accordingly, this set of commits aims to improve the numerical stability of analytical eigendecompositions, and to provide a group of verification tests to prevent future breaks in the workflow.

unit-test-notebooks-17-Feb-20.zip

Resolved bugs

#1311 (closed) #1312 (closed) #1527 #1575 #1596

Risks

Low.

polynomialEqns and analytical eigendecomposition routines were considerably isolated from the rest of the code.

@mark

Edited Feb 17, 2020 by Kutalmış Berçin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature-analytic-eigen