Skip to content
Snippets Groups Projects

ENH: improve access to the inner content of turbulence models

Merged Kutalmış Berçin requested to merge feature-turbModel-access into develop
All threads resolved!

WIP for Clang compilation test. log.linux64GccDPInt32Opt.zip (Gcc 7.4) log.linux64ClangDPInt32Opt.zip (LLVM 9.0) testLoopReport.PASS.zip

Summary

The commits provide access to:

  • omega field estimations for non-omega turbulence models,
  • model coefficients of turbulence models for fvOptions.

Resolved bugs (If applicable)

n/a

Details of new models (If applicable)

n/a

Risks

  • No change to the current behaviour
Edited by Kutalmış Berçin

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 2 commits

    • 7373521c - ENH: add virtual omega to turbulenceModels
    • a22fef1c - ENH: register internal fields of kOmegaSST

    Compare with previous version

  • added 1 commit

    • 37e6383b - ENH: register internal fields of kOmegaSST

    Compare with previous version

  • Kutalmış Berçin resolved all discussions

    resolved all discussions

  • added 2 commits

    • 72667165 - ENH: add virtual omega to turbulenceModels
    • 7ab12ae0 - ENH: register internal fields of kOmegaSST

    Compare with previous version

  • added 3 commits

    • 2c4b639e - 1 commit from branch develop
    • 79dd5ffd - ENH: add virtual omega to turbulenceModels
    • 43e7098a - ENH: register internal fields of kOmegaSST

    Compare with previous version

  • Kutalmış Berçin changed the description

    changed the description

  • Kutalmış Berçin changed the description

    changed the description

  • looks good - maybe consider a 2-eqn base class in the future to reduce the code duplication

  • Andrew Heather added 8 commits

    added 8 commits

    Compare with previous version

  • Andrew Heather mentioned in commit b69360fe

    mentioned in commit b69360fe

  • Adjustments for OpenQBMM pending on github 150

    @albertop and @kuti - we might wish to put in a concerted effort to merge in the OpenQBMM turbulence modifications if possible.

  • Hi @mark and @kuti ,

    I think it would be possible.

    However, there has been a long-standing issue in OF in this area which I wanted to tackle for a while but never had a chance. Kinetic theory models and non-Newtonian stress models (e.g. Maxwell) are treated as turbulence models, but they really are laminar stress models. The current implementation prevents some developments in both areas to be easily done. For example, if one is using the kinetic theory model, no turbulence model can be selected for that phase. Similar issues affect non-Newtonian models.

    What do you think about moving these models out of the turbulence framework and make them usable with turbulence models?

    The kinetic theory would need to access the epsilon field so that more recent models for dilute gas-particle flows can be incorporated (epsilon is needed in some source terms for Theta), but that can be achieved with lookup. The major challenge I see is changing how the calculation of laminar stresses, which affects nearly all turbulence models, since the divergence of the stress tensor is returned by divREff and the assumption is that laminar stresses assume Newtonian flow.

  • Please register or sign in to reply
    Loading