Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • openfoam openfoam
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 426
    • Issues 426
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Development
  • openfoamopenfoam
  • Merge requests
  • !367

AMI code enhancements

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Andrew Heather requested to merge feature-ami into develop Jun 09, 2020
  • Overview 16
  • Commits 12
  • Changes 69

Summary

Note: this is beta-level code and will receive further updates in future releases

This change set includes:

  • New option for cyclicAMI and cyclicACMI patches to perform topological updates to enforce a 1-to-1 match between source and target patches to ensure conservation across AMI patches and greatly reduced pressure field perturbations. Changes based on ref [1]
  • Deprecated directAMI; replaced by nearestFaceAMI
  • Significant code refactoring

Resolved bugs (If applicable)

  • General AMI conservation issues/noisy pressure predictions

Details of new models (If applicable)

  • Backwards compatibility [should be] maintained

  • New topological changes triggered by using a special mesh motion solver: dynamicFvMesh dynamicMotionSolverFvMeshAMI;

    • this may be absorbed into the 'standard' dynamicMotionSolverFvMesh model in future releases
  • Test case: mixerVesselAMI2D_with-boundary-layers.tgz

dynamicMotionSolverFvMesh dynamicMotionSolverFvMeshAMI
plot v2006 plot v2006
plot v1912

Note: since the AMI code triggers topological updates, to reconstruct parallel cases:

  • use reconstructParMesh to reconstruct the mesh at each time, followed by reconstructPar to reconstruct the fields; or

  • use redistributePar -reconstruct to reconstruct both mesh and fields (in parallel)

  • Code refactoring has enabled greater control of the AMI; the AMIMethod can now be set in the polyMesh/boundary file, e.g.

    AMI2
    {
        type            cyclicAMI;
        inGroups        1(cyclicAMI);
        nFaces          96;
        startFace       6336;
        matchTolerance  0.0001;
        transform       noOrdering;
        neighbourPatch  AMI1;
 
        // New optional entries
        AMIMethod       faceAreaWeightAMI;
        restartUncoveredSourceFace 1;
    }

Deprecations

The directAMI method has been deprecated and replaced by the faster and more robust, new nearestFaceAMI method. The new method creates a 1-to-1 mapping based on the nearest face.

Risks

  • Significant change to AMI code
  • Not only affects cyclic patches, but other areas of the code that make use of the tooling, e.g.:
    • mapped patches
    • mapFieldsPar
    • region models (film modelling)
    • mapping function objects

Known issues/to check

When using dynamicMotionSolverFvMeshAMI

  • restart behaviour not currently available

Tests

Checked on the following cases:

  • pimpleFoam/laminar/mixerVesselAMI2D
  • pimpleFoam/RAS/oscillatingInletACMI2D
  • XiDyMFoam/annularCombustorTurbine
  • {customer turbo machinery}

For each, the dynamicMotionSolverFvMesh option recovers v1912 behaviour

References

[1] H.J. Aguerre, S. Márquez Damián J.M. Gimenez, N.M.Nigro, Conservative handling of arbitrary non-conformal interfaces using an efficient supermesh, Journal of Computational Physics 335(15)21-49. 2017. https://doi.org/10.1016/j.jcp.2017.01.018

Acknowledgements

  • Many thanks to Horacio Aguerre @aguerrehoracio and Santiago Márquez @santiagomarquezd for bringing the methodology to our attention and for many useful discussions and testing throughout these developments.
Edited Jun 24, 2020 by Andrew Heather
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature-ami