long-term maintenance improvement for runTime selection tables

Reworked selection infrastructure to support reporting version changes for particular lookup methods. For this to work, all raw lookups in the selection tables need to be passed through an accessor method. Independent of this, the old implementation for runTime selection could be modernized to use unique_ptr for the memory management instead of the clunkier manual deletion mechanisms.

The result is a slightly cleaner calling interface, but it is also possible to continue with table-based lookups as before. Does not break existing code APIs, but is not ABI identical.

requested review from @kuti

assigned to @andy

@Prashant - could you kick off a test with your gcc-4.8.5 setup and see what breaks?

Hi @andy - marked as 'draft' to prevent accidental merging, but there isn't anything pending from my side. Just waiting for possible regression reports etc.

added 1 commit

• 585a026b - ENH: use new runTime accessors

Compare with previous version

@Prashant

I got a compilation error from a git-clone-based (i.e. clean) compilation. Attached a reduced log.

Could you confirm whether you get the same error? Confirmed.

    base0    = work
    base1    = compilationTest
    api      = 2107
    patch    = 0
    HEAD     = 585a026
    version  = com
    compiler = Gcc (system)
             = gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-39)
    mpi      = SYSTEMOPENMPI
             = mpirun (Open MPI) 4.0.3
    OS       = Description:	CentOS Linux release 7.7.1908 (Core)
    labels   = 32
    opts     = linux64GccDPInt32Opt

reducedLog.linux64GccDPInt32Opt

This will need to be looked as more (Sept). Looks like clang accepts a number of things that gcc does not. The changes in the declarations mean that there seem to be a number of places where surfaceMesh is incomplete (declared only via surfaceFieldsFwd.H), but not actually available when the table is created.

...

added 153 commits

• 585a026b...c9333a5a - 147 commits from branch develop
• f5896042 - ENH: improve isolation of basicThermo internals (as private)
• 077a8715 - ENH: rename runTime selection typedefs
• 8efd22e1 - ENH: refactored and simplified runtime declaration macros
• 67fd0c30 - ENH: add error::master() static for low-level messages
• 2b94a342 - ENH: define singleton-style lookups for runTime selection, alias handling
• 2d2f8933 - ENH: use singleton method for accessing runtime selection

Compare with previous version

resolved all threads

As discussed, delaying full use of unique_ptr (possibly indefinitely). The manual memory handling very largely mirrors the current (proven) status quo. Does however include the singleton access function, which is what gives us the hooks for compatibility/upgrade messages.

marked this merge request as ready

• ran tutorial Alltest. Only the known test-mode fails, nothing new.

marked this merge request as draft

marked this merge request as ready

@kuti - the gcc issues are gone. They were mostly related to a slightly different data encapsulation that we (@andy and I) have now decided against (no major benefit, possible risk), which was also more sensitive to incomplete types.

marked this merge request as draft

Nope, the module changes slipped in there. Forgot about them.

added 9 commits

• 2d2f8933...83fd1c95 - 3 commits from branch develop
• c500f193 - ENH: improve isolation of basicThermo internals (as private)
• f1a77708 - ENH: rename runTime selection typedefs
• 7fcf5701 - ENH: refactored and simplified runtime declaration macros
• ea1ddcfa - ENH: add error::master() static for low-level messages
• 502d3eda - ENH: define singleton-style lookups for runTime selection, alias handling
• 83b76176 - ENH: use singleton method for accessing runtime selection

Compare with previous version

marked this merge request as ready

resolved all threads

marked this merge request as draft

added 8 commits

• 83b76176...9e56dd40 - 2 commits from branch develop
• 3416151d - ENH: improve isolation of basicThermo internals (as private)
• 7f8ecd98 - ENH: rename runTime selection typedefs
• 0bd113f5 - ENH: refactored and simplified runtime declaration macros
• 794e23e0 - ENH: add error::master() static for low-level messages
• 4fc6ec1d - ENH: define singleton-style lookups for runTime selection, alias handling
• ba8d6bdd - ENH: use singleton method for accessing runtime selection

Compare with previous version

marked this merge request as ready

@andy - changed the two items and rebased on develop. Ready.

Thanks - all good

mentioned in commit 38bf3016

merged