Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • openfoam openfoam
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 426
    • Issues 426
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Development
  • openfoamopenfoam
  • Merge requests
  • !486

ENH: Improve the handling of wall-function coefficients and blenders

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kutalmış Berçin requested to merge issue-1457-refcast into develop Aug 25, 2021
  • Overview 3
  • Commits 6
  • Changes 55

Summary

  • Fixes #1457 and #1966 (closed)
  • Improves the handling of wall-function coefficients and blenders
  • Standardises the output of wall-function entries
  • Removes redundant and inconsistent virtual specifiers
  • Modernises the code style
  • Improves header file documentation
  • Removes the blending option BINOMIAL2 from omegaWallFunction

Resolved bugs

Closes #1457, #1966 (closed)

Risks

  • Silently replaces the default blending option BINOMIAL2 of the omegaWallFunction with the option BINOMIAL with n=2. In theory, both expressions are the same. Yet numerically, both expressions will yield negligible differences in floating-point decimals.

Tests

  • Compilation (incl. submodules):
    • linux64ClangDPInt32Opt (clang11)
    • linux64GccDPInt32Opt
    • linux64GccSPDPInt64Debug
  • Alltest: No change in output with respect to the develop HEAD + no error
  • Verification: No change in output rhoSimpleFoam/simpleFoam/buoyantBoussinesqSimpleFoam
Edited May 18, 2022 by Kutalmış Berçin
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: issue-1457-refcast