BUG: collated: threaded writing accesses out-of-scope. Fixes #2257.

assigned to @mark

added 27 commits

• 62c97569...08e66a64 - 24 commits from branch develop
• 04b8a52a - ENH: decomposePar: cyclicAMI in constraints. See #2242 (closed)
• 24f0b259 - BUG: overset: FaceCellWave survive 0 cells. Fixes #2156
• d2286e59 - BUG: collated: threaded writing accesses out-of-scope. Fixes #2257 (closed).

Compare with previous version

I may have opted for a unique_ptr to manage the optional dictionary entries (and then made a deep-copy if it was actually being used), but a straight deep-copy should be fine too. Marginal overhead, especially in light of the size of other bits of data being chucked about.

@Mattijs You want to have a go at unique_ptr, or happy with it "as-is"? I'm fine either way.

merged

mentioned in commit 8746d7e4