Skip to content
Snippets Groups Projects

General enhancement to icoReactingMultiphaseInterFoam solver, sub-models and FO's

Merged Sergio Ferraris requested to merge feature-icoMulti-FOs into develop
All threads resolved!
  1. Name changing and namespace used for some multi phase class used in icoReactingMultiphaseInterFoam.
  2. Creating a new derivedFvPatch for thermal BC's (detached from TurbulenceCompressible) which allows to use phase system models in FO's. This new lib was added to all the thermal solvers
  3. Adding new diffusion-based mass transfer model to icoReactingMultiphaseInterFoam
  4. Improving consistency of Hf between phases (updated tutorials entries)
  5. HeatFlux and htc FO's are available to use with icoReactingMultiphaseInterFoam

NOTE: There is memory leak problem at the end of the run when using icoReactingMultiphaseInterFoam and 'fieldFunctionObjects' is loaded usng lddOpen. NEED TO BE REVIEWED

Edited by Kutalmış Berçin

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Kutalmış Berçin resolved all threads

    resolved all threads

  • Kutalmış Berçin
  • Kutalmış Berçin
  • Kutalmış Berçin
  • Kutalmış Berçin added 159 commits

    added 159 commits

    • 099b6876...601f5410 - 150 commits from branch develop
    • 93b14b40 - ENH: derivedFvPatchFluidThermo: new thermal-BC library
    • 41483800 - ENH: multiphaseInter: new namespace for various phase-system models
    • cd343a0e - ENH: Allwmake: reorder various compilation steps
    • edbb441c - ENH: multiphaseInterHtcModel: new heatTransferCoeff function object model
    • 73cfb362 - BUG: Fixing kappaEff(label patchi) in multiphaseInterSystem
    • 1783db75 - BUG: interfaceHeatResistance: remove max condensation limiter
    • 330220fe - ENH: Consistent Hf treatment for phases
    • 050f54bc - ENH: diffusionGasEvaporation: new diffusion based mass transfer model
    • 5f6790fd - TUT: poolEvaporationMultiComponent: new tutorial for icoReactingMultiphaseInterFoam

    Compare with previous version

  • added 2 commits

    • c55f3555 - ENH: diffusionGasEvaporation: new diffusion based mass transfer model
    • 107cd34c - TUT: poolEvaporationMultiComponent: new tutorial for icoReactingMultiphaseInterFoam

    Compare with previous version

  • Kutalmış Berçin resolved all threads

    resolved all threads

  • @andy , @mark : In the light that you'd like to change the name of this library I am proposing some names: thermalFunctions compressibleThermalTools

  • Kutalmış Berçin resolved all threads

    resolved all threads

    • linux64ClangDPInt32Opt (clang11)
    • linux64GccDPInt32Opt
    • linux64GccSPDPInt64Debug
    • Alltest: No new error
  • the Alltest hangs (both for feature-icoMulti-FOs and feature-icoMulti-FOs.orig branches). inspecting the reason.

    • Resolved by Kutalmış Berçin

      Hello @albertop - just for a heads up.

      OpenQBMM may need to add the new lib -I$(LIB_SRC)/derivedFvPatchFluidThermo/lnInclude \ and -lderivedFvPatchFluidThermo \ accordingly to the following after the merge :

      modules/OpenQBMM/applications/solvers/multiphase/polydisperseBubbleFoam/Make/options
      modules/OpenQBMM/applications/solvers/multiphase/interfacialModels/Make/options 
      modules/OpenQBMM/applications/solvers/multiphase/denseAGFoam/Make/options          
      modules/OpenQBMM/applications/solvers/multiphase/phaseCompressibleTurbulenceModels/Make/options
      modules/OpenQBMM/applications/solvers/populationBalance/pbeFoam/Make/options       
      modules/OpenQBMM/applications/solvers/populationBalance/pbeTransportFoam/Make/options
      modules/OpenQBMM/applications/solvers/populationBalance/buoyantPbePimpleFoam/Make/options
      modules/OpenQBMM/applications/solvers/mixing/mixingTransportFoam/Make/options   
      modules/OpenQBMM/applications/solvers/compressible/explicitRhoFoam/compressiblePbeTransportFoam/Make/options
      modules/OpenQBMM/applications/solvers/compressible/explicitRhoFoam/Make/options 
      modules/OpenQBMM/applications/solvers/velocityDistributionTransport/phaseModel/Make/options
      modules/OpenQBMM/applications/solvers/velocityDistributionTransport/diluteVdfTransportFoam/Make/options
      modules/OpenQBMM/applications/solvers/velocityDistributionTransport/oneWayCoupledVdfTransportFoam/Make/options
      modules/OpenQBMM/applications/solvers/velocityDistributionTransport/phaseCompressibleTurbulenceModels/Make/options
      
      
      modules/OpenQBMM/src/quadratureMethods/quadratureApproximations/Make/options    
      modules/OpenQBMM/src/quadratureMethods/populationBalanceModels/Make/options     
      modules/OpenQBMM/src/quadratureMethods/mixingModels/Make/options
  • added 1 commit

    • ebdd5c65 - WIP: WILL-BE-SQUASHED: missing libs

    Compare with previous version

  • added 1 commit

    • 7d80ed2f - WIP: WILL-BE-SQUASHED: reorder libs

    Compare with previous version

    • Resolved by Andrew Heather

      @andy @Sergio @kuti - will need to decide on library name and rebasing fairly soon. I've reopened the release activities for OpenQBMM, but it will be even uglier there.

      For example in the Make/options (to allow continued compilation with openfoam2112 etc):

      #if (OPENFOAM >= 2206)
      -lsomeLibraryName
      #endif

      I think that extra include line to a non-existent directory will not matter (it is pretty generous there), but the final link line will need to be correct.

      I don't believe that this affects swak4foam @bgschaid, since I don't think it has any multiphase solvers. On the other hand, yet another pre-processor define is always something nice for swak ;)

  • added 1 commit

    Compare with previous version

  • added 9 commits

    • 522c425b - ENH: derivedFvPatchFluidThermo: new thermal-BC library
    • 8f87b071 - ENH: multiphaseInter: new namespace for various phase-system models
    • 15164e66 - ENH: Allwmake: reorder various compilation steps
    • c20a7b85 - ENH: multiphaseInterHtcModel: new heatTransferCoeff function object model
    • b8ff1d1b - BUG: Fixing kappaEff(label patchi) in multiphaseInterSystem
    • ced67779 - BUG: interfaceHeatResistance: remove max condensation limiter
    • d060f013 - ENH: Consistent Hf treatment for phases
    • 4f594eb6 - ENH: diffusionGasEvaporation: new diffusion based mass transfer model
    • 6d7b4481 - TUT: poolEvaporationMultiComponent: new tutorial for icoReactingMultiphaseInterFoam

    Compare with previous version

  • Kutalmış Berçin resolved all threads

    resolved all threads

  • added 18 commits

    • 6d7b4481...e5cb375a - 9 commits from branch develop
    • 50badbd5 - ENH: derivedFvPatchFluidThermo: new thermal-BC library
    • 637cc130 - ENH: multiphaseInter: new namespace for various phase-system models
    • 328a364c - ENH: Allwmake: reorder various compilation steps
    • b7444b51 - ENH: multiphaseInterHtcModel: new heatTransferCoeff function object model
    • 4a6dd4f6 - BUG: Fixing kappaEff(label patchi) in multiphaseInterSystem
    • 90569da0 - BUG: interfaceHeatResistance: remove max condensation limiter
    • 1a42580a - ENH: Consistent Hf treatment for phases
    • a1840bc9 - ENH: diffusionGasEvaporation: new diffusion based mass transfer model
    • b72d94b0 - TUT: poolEvaporationMultiComponent: new tutorial for icoReactingMultiphaseInterFoam

    Compare with previous version

  • added 11 commits

    • b72d94b0...8ac11f10 - 2 commits from branch develop
    • 0ad306b9 - ENH: thermoTools: new library for thermophysics tools
    • 7050776f - ENH: multiphaseInter: new namespace for various phase-system models
    • d712cb49 - ENH: multiphaseInterHtcModel: new heatTransferCoeff function object model
    • a325bd1e - BUG: multiphaseInterSystem: fix kappaEff functions
    • bad20745 - BUG: interfaceHeatResistance: remove max condensation limiter
    • bff7c174 - ENH: multiphaseInter: ensure consistent Hf treatment for phases
    • 825da4d9 - ENH: diffusionGasEvaporation: new diffusion based mass transfer model
    • ba912178 - TUT: poolEvaporationMultiComponent: new tutorial for icoReactingMultiphaseInterFoam
    • 5c7df7cd - CONFIG: set API level to 2206

    Compare with previous version

  • added 9 commits

    • 49def8c8 - ENH: thermoTools: new library for thermophysics tools
    • 3014f5b8 - ENH: multiphaseInter: new namespace for various phase-system models
    • 05d58a63 - ENH: multiphaseInterHtcModel: new heatTransferCoeff function object model
    • b49d062c - BUG: multiphaseInterSystem: fix kappaEff functions
    • 9ebcbfb5 - BUG: interfaceHeatResistance: remove max condensation limiter
    • 88844bbd - ENH: multiphaseInter: ensure consistent Hf treatment for phases
    • ecb8df17 - ENH: diffusionGasEvaporation: new diffusion based mass transfer model
    • f5fac3d3 - TUT: poolEvaporationMultiComponent: new tutorial for icoReactingMultiphaseInterFoam
    • 49b6642b - CONFIG: set API level to 2206

    Compare with previous version

  • added 10 commits

    • e96990c8 - 1 commit from branch develop
    • 955fce98 - ENH: thermoTools: new library for thermophysics tools
    • 4a46d7c0 - ENH: phaseSystemModels: new namespaces for various submodels
    • 207eba00 - ENH: functionObjects: rearrange the location of phaseSystemModels function objects
    • 6a0477f4 - BUG: multiphaseInterSystem: fix kappaEff functions
    • 8368401b - BUG: interfaceHeatResistance: remove max condensation limiter
    • fd7e5dd6 - ENH: multiphaseInter: ensure consistent Hf treatment for phases
    • 55f5b2cc - ENH: diffusionGasEvaporation: new diffusion based mass transfer model
    • 35f39890 - TUT: poolEvaporationMultiComponent: new tutorial for icoReactingMultiphaseInterFoam
    • 7c79bdf6 - CONFIG: set API level to 2206

    Compare with previous version

  • added 2 commits

    • 59cdf9cc - TUT: poolEvaporationMultiComponent: new tutorial for icoReactingMultiphaseInterFoam
    • 7a9caac6 - CONFIG: set API level to 2206

    Compare with previous version

  • added 8 commits

    • 9a80d0d5 - ENH: thermoTools: new library for thermophysics tools
    • 45c3ba0e - ENH: phaseSystemModels: new namespaces for various submodels
    • ddb3e394 - ENH: functionObjects: rearrange the location of phaseSystemModels function objects
    • 8f8612fd - BUG: multiphaseInterSystem: fix kappaEff functions
    • 0f0a5c5c - BUG: interfaceHeatResistance: remove max condensation limiter
    • d91fe9a6 - ENH: multiphaseInter: ensure consistent Hf treatment for phases
    • 618aee84 - ENH: diffusionGasEvaporation: new diffusion based mass transfer model
    • c0581fe8 - TUT: poolEvaporationMultiComponent: new tutorial for icoReactingMultiphaseInterFoam

    Compare with previous version

  • Kutalmış Berçin marked this merge request as ready

    marked this merge request as ready

  • Andrew Heather resolved all threads

    resolved all threads

  • Andrew Heather mentioned in commit ebac6c9b

    mentioned in commit ebac6c9b

  • Just a note: further work will be needed for this directory.

  • Mark OLESEN mentioned in issue #2520

    mentioned in issue #2520

  • Mark OLESEN mentioned in commit 97c8e62f

    mentioned in commit 97c8e62f

  • Please register or sign in to reply
    Loading