Skip to content
Snippets Groups Projects

WIP: Issue 104 keep sampled geo info

Closed Mark OLESEN requested to merge issue-104-keep-sampled-geo-info into master

Originally slated for the 1606 code base (now master). Should be rebased prior to merging into current development line.

Merge request reports

Approval is optional

Merged by avatar (Jul 6, 2025 6:46am UTC)

Merge details

  • Changes merged into with .
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mark OLESEN Marked this merge request as a Work In Progress

    Marked this merge request as a Work In Progress

  • mentioned in issue #104 (closed)

  • compilation error

    mergedSurf/mergedSurf.C: In constructor 'Foam::mergedSurf::mergedSurf(const Foam::meshedSurf&, Foam::scalar)':
    mergedSurf/mergedSurf.C:47:5: error: type 'Foam::mergedSurf' is not a direct base of 'Foam::mergedSurf'
  • changing mergedSurf->meshedSurf on line 47 seem to work. But fails further

    sampledSurface/writers/nastran/nastranSurfaceWriter.C: In member function 'Foam::Ostream& Foam::nastranSurfaceWriter::writeFooter(Foam::Ostream&, const Foam::meshedSurf&) const':
    sampledSurface/writers/nastran/nastranSurfaceWriter.C:360:19: error: expected initializer before ':' token
    sampledSurface/writers/nastran/nastranSurfaceWriter.C:478:1: error: expected primary-expression at end of input
    sampledSurface/writers/nastran/nastranSurfaceWriter.C:478:1: error: expected ';' at end of input
    sampledSurface/writers/nastran/nastranSurfaceWriter.C:478:1: error: expected primary-expression at end of input
    sampledSurface/writers/nastran/nastranSurfaceWriter.C:478:1: error: expected ')' at end of input
    sampledSurface/writers/nastran/nastranSurfaceWriter.C:478:1: error: expected statement at end of input
    sampledSurface/writers/nastran/nastranSurfaceWriter.C:478:1: error: expected '}' at end of input
    sampledSurface/writers/nastran/nastranSurfaceWriter.C:478:1: warning: no return statement in function returning non-void
    Edited by Prashant Sonakar
  • Author Maintainer

    This is due to having some C++11 syntax. I guess that I wasn't careful enough about older compiler versions.

    • line 360 (nastran writer) uses a range-based for, which available starting with gcc 4.6
    • line 47 (mergedSurf) uses a delegating constructor, which is available starting with gcc 4.7

    I'll downgrade to older syntax and push now.

  • Mark OLESEN Added 1 commit:

    Added 1 commit:

    • fa9c6af3 - COMPILE: avoid newer C++11 features that were used in solving issue #104 (closed)
  • Admin Target branch changed from develop to merge-foundation

    Target branch changed from develop to merge-foundation

    By Andrew Heather on 2016-10-04T09:33:00 (imported from GitLab project)

  • Mark OLESEN Target branch changed from merge-foundation to master

    Target branch changed from merge-foundation to master

  • Mark OLESEN Mentioned in merge request !75 (merged)

    Mentioned in merge request !75 (merged)

  • Mark OLESEN Status changed to closed

    Status changed to closed

  • Author Maintainer

    Functionality already merged into develop.

Please register or sign in to reply
Loading