Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • openfoam openfoam
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 442
    • Issues 442
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • Deployments
    • Deployments
    • Releases
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • Development
  • openfoamopenfoam
  • Merge requests
  • !591

BUG: extraConvection in ATC missing a multiplication with ATClimiter

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Vaggelis Papoutsis requested to merge fix-ATC-extraConvection into master Feb 02, 2023
  • Overview 1
  • Commits 1
  • Changes 2

Resolved bugs (If applicable)

The bug is described in #2687

In the 'standard' and 'UaGradU' options for the ATC term of the adjoint equations, there is an option to add 'aritificial dissipation', by adding and subtracting a multiple of the adjoint convection term with different discretizations. The implicit part was not multiplied with the ATClimiter whereas the explicit one was, leading to mismatched contributions in the areas affected by the ATClimiter, which could affect the sensitivity derivatives.

This can be replicated using the sbend tutorial under

$FOAM_TUTORIALS/incompressible/adjointOptimisationFoam/sensitivityMaps/sbend/turbulent/lowRe/singlePoint

In the figures that follow, 'n' stands for nMask and 'e' for extraConvection in the setup of the ATC model. As 'n' increases, the sensitivity map should tend towards that of canceling the ATC everywhere. With the previous code behavior, this was not the case when n \neq 0, e \ne 0 (figure at the bottom left). The expected behavior is retrieved with the current fix (figure at the bottom right).

sbend_ATC

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-ATC-extraConvection