Draft: use sparse storage and data exchange for PstreamBuffers

Changes the PstreamBuffers storage to a Map of buffers and use NBX for exchanging sizes.

changed milestone to %v2306

requested review from @alonzameret

assigned to @andy

After testing/validation, will remove the pre-processor define (Foam_PstreamBuffers_dense) and add some extra cleanup

added 1 commit

• 3122f84e - ENH: sparse storage and data exchange for PstreamBuffers

Compare with previous version

added 3 commits

• 3122f84e...cbb15337 - 2 commits from branch develop
• f93c53af - ENH: sparse storage and data exchange for PstreamBuffers

Compare with previous version

Hi, From a quick overview of the code, I believe the **Map ** implementation causes the following methods found within PStreamBuffers.H to be incorrect:

//- Range of ranks indices associated with PstreamBuffers
UPstream::rangeType allProcs() const noexcept
{
     // Proc 0 -> nProcs (int value)
     return UPstream::rangeType(static_cast<int>(nProcs_));
}
//- Range of sub-processes indices associated with PstreamBuffers
UPstream::rangeType subProcs() const noexcept
{
     // Proc 1 -> nProcs (int value)
     return UPstream::rangeType(1, static_cast<int>(nProcs_-1));
}

The range of the processors is no longer contiguous as it was when using List

That one is actually still ok, since this is the range of addressable ranks, not necessarily those that actually contain anything.

added 65 commits

• f93c53af...f75af788 - 59 commits from branch develop
• d3867a2d - SUBMODULE: minor updates for external-solver
• 99bf27cb - STYLE: use PstreamBuffers allProcs() addressing in zoneDistribute
• d4d2eceb - ENH: support run-time PstreamBuffers algorithm selection (advanced option)
• 8e0c86ee - CONFIG: accept -decompose-dict=xyz for Run functions and mpirunDebug
• 75485a2f - ENH: improve diagnostic fields for checkFaMesh -write-vtk
• 05e2d071 - WIP: PstreamBuffers with hybrid PEX/NBX exchange

Compare with previous version

added 4 commits

• f4fa4e8f - ENH: support run-time PstreamBuffers algorithm selection (advanced option)
• 6e000153 - CONFIG: accept -decompose-dict=xyz for Run functions and mpirunDebug
• 92b0125e - ENH: improve diagnostic fields for checkFaMesh -write-vtk
• dc2abff8 - WIP: PstreamBuffers with hybrid PEX/NBX exchange

Compare with previous version

added 4 commits

• 82c0b360 - ENH: support run-time PstreamBuffers algorithm selection (advanced option)
• 4284d02c - CONFIG: accept -decompose-dict=xyz for Run functions and mpirunDebug
• d5c0852d - ENH: improve diagnostic fields for checkFaMesh -write-vtk
• 5cf5af9d - WIP: PstreamBuffers with hybrid PEX/NBX exchange

Compare with previous version

Closing out. The idea of maps for managing logic was a nice idea, but this is better handled using the hybrid NBX/PEX with lists (currently staged as an option in the develop branch) - this allows more reuse of components etc.

closed