Draft: use sparse storage and data exchange for PstreamBuffers
Changes the PstreamBuffers storage to a Map of buffers and use NBX for exchanging sizes.
Merge request reports
Activity
Filter activity
changed milestone to %v2306
requested review from @alonzameret
assigned to @andy
added 1 commit
- 3122f84e - ENH: sparse storage and data exchange for PstreamBuffers
added 3 commits
-
3122f84e...cbb15337 - 2 commits from branch
develop
- f93c53af - ENH: sparse storage and data exchange for PstreamBuffers
-
3122f84e...cbb15337 - 2 commits from branch
Hi, From a quick overview of the code, I believe the **Map ** implementation causes the following methods found within PStreamBuffers.H to be incorrect:
//- Range of ranks indices associated with PstreamBuffers UPstream::rangeType allProcs() const noexcept { // Proc 0 -> nProcs (int value) return UPstream::rangeType(static_cast<int>(nProcs_)); } //- Range of sub-processes indices associated with PstreamBuffers UPstream::rangeType subProcs() const noexcept { // Proc 1 -> nProcs (int value) return UPstream::rangeType(1, static_cast<int>(nProcs_-1)); }
The range of the processors is no longer contiguous as it was when using List
Edited by Alon Zameretadded 65 commits
-
f93c53af...f75af788 - 59 commits from branch
develop
- d3867a2d - SUBMODULE: minor updates for external-solver
- 99bf27cb - STYLE: use PstreamBuffers allProcs() addressing in zoneDistribute
- d4d2eceb - ENH: support run-time PstreamBuffers algorithm selection (advanced option)
- 8e0c86ee - CONFIG: accept -decompose-dict=xyz for Run functions and mpirunDebug
- 75485a2f - ENH: improve diagnostic fields for checkFaMesh -write-vtk
- 05e2d071 - WIP: PstreamBuffers with hybrid PEX/NBX exchange
Toggle commit list-
f93c53af...f75af788 - 59 commits from branch
added 4 commits
Toggle commit listadded 4 commits
Toggle commit list
Please register or sign in to reply