Draft: INT: introduce demand-driven fvSchemes and fvSolution

• functionality similar to that introduced by openfoam.org

  fvSchemes/fvSolution now demand-driven and accessed by their respective member functions schemes() and solution().

  This means that the corresponding system files are not required upon construction (which simplifies initialization) and potentially allows supporting different file locations (TBD).

changed milestone to %v2312

added enhancement label

requested review from @Mattijs

assigned to @andy

test loop currently showing some errors, but placed here for discussion, resolution, another set of eyes etc.

marked this merge request as draft

added 4 commits

• 92d7e2b7 - ENH: support 'if-present' handling of relaxation coefficients
• aac2fd8d - ENH: support direct lookup of solver controls
• d043a76e - INT: introduce demand-driven fvSchemes and fvSolution
• f8373f7f - ENH: use demand-driven schemes and solution w/o compatibility layer

Compare with previous version

approved this merge request

@Prashant - can you take for a spin?

A few failures... questionable code:

src/dynamicFaMesh/interfaceTrackingFvMesh/functionObjects/writeFreeSurface/writeFreeSurface.C:                    mesh.lookupObject<dynamicFvMesh>("fvSolution")
src/dynamicFaMesh/interfaceTrackingFvMesh/fvPatchFields/freeSurfacePressure/freeSurfacePressureFvPatchScalarField.C:                mesh.lookupObject<dynamicFvMesh>("fvSolution")
src/dynamicFaMesh/interfaceTrackingFvMesh/fvPatchFields/freeSurfaceVelocity/freeSurfaceVelocityFvPatchVectorField.C:                mesh.lookupObject<dynamicFvMesh>("fvSolution")

• cast mesh to dynamicFvMesh?

Case incompressible/pimpleFoam/LES/wallMountedHump/results/SpalartAllmarasDDES-DeltaOmegaTilde-useSigmaTrue

Entry 'divSchemes' not found in dictionary "processor2/system/fvSchemes"

added 36 commits

• f8373f7f...9c8c69a5 - 25 commits from branch develop
• fa2c32b4 - 1 earlier commit
• 3658fa87 - FIX: avoid doubled dbDir() in fileOperation::readObjects (#3037 (closed))
• 4cc8d9f4 - ENH: use thisDb reference when referencing/creating finite-area fields
• 0a5de95d - FIX: avoid questionable lookup and casting for interfaceTrackingFvMesh
• b6187c8c - ENH: minor simplifications for handling region meshes
• e08003a8 - ENH: harmomize schemes-lookup and solution internal accessor names
• 1bc8299e - ENH: support 'if-present' handling of relaxation coefficients
• cdc16d60 - ENH: support direct lookup of solver controls
• 1bb5aabb - INT: introduce demand-driven fvSchemes and fvSolution
• 42e50422 - ENH: use demand-driven schemes and solution w/o compatibility layer
• a5980c7b - GIT: remove supplementary IOobjectOption handling for faMesh

Compare with previous version

• questionable code revised.
• not sure if failure in wallMountedHump was a temporary artefact.

@Prashant - can you kick off another small test loop?

marked this merge request as ready

added 15 commits

• a5980c7b...9a7e97ab - 4 commits from branch develop
• 4e51f5cf - 1 earlier commit
• 458b2ce4 - FIX: avoid doubled dbDir() in fileOperation::readObjects (#3037 (closed))
• 96079bab - ENH: use thisDb reference when referencing/creating finite-area fields
• a3783b3a - FIX: avoid questionable lookup and casting for interfaceTrackingFvMesh
• fd93bbfa - ENH: minor simplifications for handling region meshes
• ee4a4aac - ENH: harmomize schemes-lookup and solution internal accessor names
• 95b988e5 - ENH: support 'if-present' handling of relaxation coefficients
• 23f20544 - ENH: support direct lookup of solver controls
• 94625e0f - INT: introduce demand-driven fvSchemes and fvSolution
• 50473acc - ENH: use demand-driven schemes and solution w/o compatibility layer
• 2e5a87de - GIT: remove supplementary IOobjectOption handling for faMesh

Compare with previous version

resolved all threads

Hi @Prashant - rebased again

Hi Mark,

Current version looks better, however still couple of instances where divScheme is not read into. Attached current status.log.error

They have weird stuff like case directory "/gpfsprocessor0" - seems to be something else. Either fileHandler, your scripts/setup or unknown. However, not even sure why/where the reconstruct should need div schemes in the first place either.

added 19 commits

• 2e5a87de...13352861 - 16 commits from branch develop
• 916d3b90 - INT: introduce demand-driven fvSchemes and fvSolution
• 205719d4 - ENH: use demand-driven schemes and solution w/o compatibility layer
• 47062b61 - GIT: remove supplementary IOobjectOption handling for faMesh

Compare with previous version

marked this merge request as draft

Defer as draft until after release!