Improve streaming matrix and internal memory management
All threads resolved!
All threads resolved!
- Adjust procLduMatrix etc to allow default construct and reading from stream, which enables simpler transfer of data between ranks.
- Internal memory management with unique_ptr (modernize and simplifies code).
Merge request reports
Activity
changed milestone to %v2406
added enhancement label
requested review from @kuti
assigned to @kuti
Includes changes for !669 (merged) as well, so can just test this branch (as desired).
added 4 commits
-
ce57cfa1...05194796 - 2 commits from branch
develop
- 2b79fc36 - ENH: handle matrix demand-driven internals with unique_ptr
- e819ec12 - ENH: improve procLduMatrix streaming and assembly of LUscalarMatrix
-
ce57cfa1...05194796 - 2 commits from branch
- Resolved by Kutalmış Berçin
For some reason, I got the following compilation error after cherry-picking two commits on top of the develop - and executing the compilation with
./Allwmake -j -l -q
:OpenFOAM/work/update-matrix-streaming/src/OpenFOAM/lnInclude/GAMGAgglomeration.H:266:9: error: no matching constructor for initialization of 'Foam::assemblyFaceAreaPairGAMGAgglomeration'
Environment:
base1 = update-matrix-streaming api = 2312 patch = 240220 compiler = Clang (system) = clang version 15.0.7 mpi = SYSTEMOPENMPI = mpirun (Open MPI) 1.10.7.0.5e373bf1fd OS = Description: openSUSE Leap 15.5 opts = linux64ClangDPInt32Opt
Would you mind checking it?
I'll redo a clean compilation now.Fails with the clean compilation as well.Edited by Kutalmış Berçin
- Resolved by Kutalmış Berçin
mentioned in commit d89ecc74
Please register or sign in to reply