ENH: solver function objects: add outer-loop convergence checks
Summary
- Introduced an outer-loop convergence check in the solver function objects to allow for loop termination when possible.
- Updated the code in
scalarTransportandenergyTransportfunction objects to modern standards.
Risks
The default value of the input entry nCorr has been changed from 0 to 1 to standardize the behavior of the solver function objects. This change should not impact behavior if nCorr is not explicitly specified. However, if nCorr is used, it needs to be increased by 1 to maintain the same output.
No risk.
Metadata
-
linux64ClangDPInt32Opt (clang15) -
linux64GccDPInt32Opt -
linux64GccSPDPInt64Debug -
Alltest: No new error/No change in existing output -
Test cases: regression-tests-feature-solver-function-objects-solution-control.zip
PS: Please squash the commits after the review.
Edited by Kutalmış Berçin