BUG: fan: bc value not updated. See #3211

The problem is present anywhere a field with constraint patch override (patchType XXX) gets calculated. In this case the RHS gets calculated with calculated and the constraint type so when this gets assigned to the LHS it is not up to date with the behaviour override.

• it will generally not be seen in solvers where the main variable is the one being solved for since it will call the correctBoundaryConditions which will fix all. It is only on those solvers where a derived variable is solved for (e.g. p_rgh instead of p).
• the override behaviour is only possible for fields that are read in from dictionary.

assigned to @andy

marked this merge request as ready

@Prashant

mentioned in issue #3211

added 21 commits

• 0ad9d140...e4f4c73b - 20 commits from branch develop
• 5f3a48c0 - BUG: fan: bc value not updated. See #3211

Compare with previous version

marked this merge request as draft

changed the description

changed the description

• Splice this into buoyantSimpleFoam:

pEqn.H

• copy the fan jump also to the 0.orig/p:

    fanCyclic_master
    {
        type            fan;
        patchType       cyclic;
        jump            uniform 0;
        value           uniform 99999;
        jumpTable       polynomial
        1((100 0));
        mode            velocity;
    }
    fanCyclic_slave
    {
        type            fan;
        patchType       cyclic;
        value           uniform 99999;
        //mode            velocity;
    }

Probably all assignments to GeometricField need the local bc update and not just the relax.

• triggering re-evaluation for any assignment (not just relaxation) produces attached:

(inlet from the left, glyphs on the master-side (blue) going straight, glyphs on the slave side (coloured) having swirl)

added 180 commits

• 5f3a48c0...dd09aa12 - 178 commits from branch develop
• 98c7bdf7 - BUG: fan: bc value not updated. See #3211
• 3ce36178 - ENH: GeometricField: prioritise constraints. See #3211.

Compare with previous version

added 1 commit

• 24d7331b - ENH: constraint: only evaluate constraint-overrides. Fixes #3211

Compare with previous version

added 1 commit

• ef89e562 - ENH: GeometricField: clean up of patch override test

Compare with previous version

marked this merge request as ready

changed the description

added 32 commits

• ef89e562...dcbd546d - 28 commits from branch develop
• 47d8eec0 - BUG: fan: bc value not updated. See #3211
• 0ac1c2b0 - ENH: GeometricField: prioritise constraints. See #3211.
• d0338735 - ENH: constraint: only evaluate constraint-overrides. Fixes #3211
• f974d492 - ENH: GeometricField: clean up of patch override test

Compare with previous version

added 1 commit

• 969fa413 - ENH: GeometricField: clean up of patch override test

Compare with previous version

added 6 commits

• 09e04003 - 1 commit from branch develop
• b93111f2 - BUG: fan: bc value not updated. See #3211
• f3777fe9 - ENH: GeometricField: prioritise constraints. See #3211.
• ca33c184 - ENH: constraint: only evaluate constraint-overrides. Fixes #3211
• de33fe48 - ENH: GeometricField: clean up of patch override test
• 0e8121c4 - ENH: GeometricField: clean up of patch override test

Compare with previous version