Skip to content
Snippets Groups Projects
  1. Apr 16, 2017
  2. Apr 12, 2017
  3. Mar 27, 2017
    • Henry Weller's avatar
      surfaceFilmModels::contactAngleForce: Added temperatureDependentContactAngleForce · cb1faea3
      Henry Weller authored
      Created a base-class from contactAngleForce from which the
      distributionContactAngleForce (for backward compatibility) and the new
      temperatureDependentContactAngleForce are derived:
      
      Description
          Temperature dependent contact angle force
      
          The contact angle in degrees is specified as a \c Function1 type, to
          enable the use of, e.g.  contant, polynomial, table values.
      
      See also
          Foam::regionModels::surfaceFilmModels::contactAngleForce
          Foam::Function1Types
      
      SourceFiles
          temperatureDependentContactAngleForce.C
      cb1faea3
  4. Feb 27, 2017
  5. Jan 30, 2017
  6. Dec 13, 2016
  7. Dec 12, 2016
  8. Dec 05, 2016
  9. Oct 07, 2016
  10. Oct 06, 2016
    • Henry Weller's avatar
      reactingTwoPhaseEulerFoam::IATE: Added wallBoiling sub-model · 164540eb
      Henry Weller authored
      to handle the size of bubbles created by boiling.  To be used in
      conjunction with the alphatWallBoilingWallFunction boundary condition.
      
      The IATE variant of the wallBoiling tutorial case is provided to
      demonstrate the functionality:
      
      tutorials/multiphase/reactingTwoPhaseEulerFoam/RAS/wallBoilingIATE
      164540eb
  11. Oct 04, 2016
  12. Sep 20, 2016
    • Henry Weller's avatar
      TurbulenceModels: Created a general base-class and selection mechanism for laminar stress models · 855f4246
      Henry Weller authored
      Renamed the original 'laminar' model to 'Stokes' to indicate it is a
      linear stress model supporting both Newtonian and non-Newtonian
      viscosity.
      
      This general framework will support linear, non-linear, visco-elastic
      etc. laminar transport models.
      
      For backward compatibility the 'Stokes' laminar stress model can be
      selected either the original 'laminar' 'simulationType'
      specification in turbulenceProperties:
      
          simulationType laminar;
      
      or using the new more general 'laminarModel' specification:
      
          simulationType laminar;
      
          laminar
          {
              laminarModel        Stokes;
          }
      
      which allows other laminar stress models to be selected.
      855f4246
  13. Jul 29, 2016
  14. Jun 24, 2016
  15. Jun 23, 2016
  16. Jun 19, 2016
  17. Jun 17, 2016
  18. Jun 14, 2016
  19. Apr 30, 2016
    • Henry Weller's avatar
      GeometricField: Renamed internalField() -> primitiveField() and... · fe43b805
      Henry Weller authored
      GeometricField: Renamed internalField() -> primitiveField() and dimensionedInternalField() -> internalField()
      
      These new names are more consistent and logical because:
      
      primitiveField():
      primitiveFieldRef():
          Provides low-level access to the Field<Type> (primitive field)
          without dimension or mesh-consistency checking.  This should only be
          used in the low-level functions where dimensional consistency is
          ensured by careful programming and computational efficiency is
          paramount.
      
      internalField():
      internalFieldRef():
          Provides access to the DimensionedField<Type, GeoMesh> of values on
          the internal mesh-type for which the GeometricField is defined and
          supports dimension and checking and mesh-consistency checking.
      fe43b805
  20. Apr 28, 2016
    • Henry Weller's avatar
      GeometricField::GeometricBoundaryField -> GeometricField::Boundary · 75ea7618
      Henry Weller authored
      When the GeometricBoundaryField template class was originally written it
      was a separate class in the Foam namespace rather than a sub-class of
      GeometricField as it is now.  Without loss of clarity and simplifying
      code which access the boundary field of GeometricFields it is better
      that GeometricBoundaryField be renamed Boundary for consistency with the
      new naming convention for the type of the dimensioned internal field:
      Internal, see commit a25a449c
      
      This is a very simple text substitution change which can be applied to
      any code which compiles with the OpenFOAM-dev libraries.
      75ea7618
  21. Apr 25, 2016
    • Henry Weller's avatar
      Completed boundaryField() -> boundaryFieldRef() · a4e2afa4
      Henry Weller authored
      Resolves bug-report http://www.openfoam.org/mantisbt/view.php?id=1938
      
      Because C++ does not support overloading based on the return-type there
      is a problem defining both const and non-const member functions which
      are resolved based on the const-ness of the object for which they are
      called rather than the intent of the programmer declared via the
      const-ness of the returned type.  The issue for the "boundaryField()"
      member function is that the non-const version increments the
      event-counter and checks the state of the stored old-time fields in case
      the returned value is altered whereas the const version has no
      side-effects and simply returns the reference.  If the the non-const
      function is called within the patch-loop the event-counter may overflow.
      To resolve this it in necessary to avoid calling the non-const form of
      "boundaryField()" if the results is not altered and cache the reference
      outside the patch-loop when mutation of the patch fields is needed.
      
      The most straight forward way of resolving this problem is to name the
      const and non-const forms of the member functions differently e.g. the
      non-const form could be named:
      
          mutableBoundaryField()
          mutBoundaryField()
          nonConstBoundaryField()
          boundaryFieldRef()
      
      Given that in C++ a reference is non-const unless specified as const:
      "T&" vs "const T&" the logical convention would be
      
          boundaryFieldRef()
          boundaryFieldConstRef()
      
      and given that the const form which is more commonly used is it could
      simply be named "boundaryField()" then the logical convention is
      
          GeometricBoundaryField& boundaryFieldRef();
      
          inline const GeometricBoundaryField& boundaryField() const;
      
      This is also consistent with the new "tmp" class for which non-const
      access to the stored object is obtained using the ".ref()" member function.
      
      This new convention for non-const access to the components of
      GeometricField will be applied to "dimensionedInternalField()" and "internalField()" in the
      future, i.e. "dimensionedInternalFieldRef()" and "internalFieldRef()".
      a4e2afa4
    • Henry Weller's avatar
      8c4f6b8f
  22. Apr 22, 2016
  23. Apr 16, 2016
  24. Mar 08, 2016
  25. Feb 26, 2016
    • Henry Weller's avatar
      OpenFOAM: Updated all libraries, solvers and utilities to use the new const-safe tmp · 78590832
      Henry Weller authored
      The deprecated non-const tmp functionality is now on the compiler switch
      NON_CONST_TMP which can be enabled by adding -DNON_CONST_TMP to EXE_INC
      in the Make/options file.  However, it is recommended to upgrade all
      code to the new safer tmp by using the '.ref()' member function rather
      than the non-const '()' dereference operator when non-const access to
      the temporary object is required.
      
      Please report any problems on Mantis.
      
      Henry G. Weller
      CFD Direct.
      78590832
  26. Feb 24, 2016
    • Henry Weller's avatar
      tmp: Improved reference count checks to provide better error diagnostics · 3a56ebf3
      Henry Weller authored
      in case of tmp misuse.
      
      Simplified tmp reuse pattern in field algebra to use tmp copy and
      assignment rather than the complex delayed call to 'ptr()'.
      
      Removed support for unused non-const 'REF' storage of non-tmp objects due to C++
      limitation in constructor overloading: if both tmp(T&) and tmp(const T&)
      constructors are provided resolution is ambiguous.
      
      The turbulence libraries have been upgraded and '-DCONST_TMP' option
      specified in the 'options' file to switch to the new 'tmp' behavior.
      3a56ebf3
  27. Feb 19, 2016
  28. Jan 10, 2016
  29. Dec 03, 2015
  30. Dec 02, 2015
    • Henry Weller's avatar
      fvOptions: Reorganized and updated to simplify use in sub-models and maintenance · 9a536b02
      Henry Weller authored
      fvOptions are transferred to the database on construction using
      fv::options::New which returns a reference.  The same function can be
      use for construction and lookup so that fvOptions are now entirely
      demand-driven.
      
      The abstract base-classes for fvOptions now reside in the finiteVolume
      library simplifying compilation and linkage.  The concrete
      implementations of fvOptions are still in the single monolithic
      fvOptions library but in the future this will be separated into smaller
      libraries based on application area which may be linked at run-time in
      the same manner as functionObjects.
      9a536b02
  31. Nov 29, 2015
  32. Nov 27, 2015
  33. Nov 24, 2015
  34. Nov 23, 2015