• Mark Olesen's avatar
    ENH: ensure that content changes in coded objects are noticed (#1293) · a85c55bb
    Mark Olesen authored
    - for codedFunctionObject and CodedSource the main code snippets
      were not included in the SHA1 calculation, which meant that many
      changes would not be noticed and no new library would be compiled.
      As a workaround, a dummy 'code' entry could be used solely for the
      purposes of generating a SHA1, but this is easily forgotten.
      We now allow tracking of the dynamicCodeContext for the coded
      objects and append to the SHA1 hasher with specific entries.
      This should solve the previous misbehaviour.
      We additionally add information about the ordering of the code
      sections. Suppose we have a coded function object (all code
      segments are optional) with the following:
          codeExecute "";
          codeWrite   #{ Info<< "Called\n"; #};
      which we subsequently change to this:
          codeExecute #{ Info<< "Called\n"; #};
          codeWrite   "";
      If the code strings are simply concatenated together, the SHA1 hashes
      will be identical. We thus 'salt' with their semantic locations,
      choosing tags that are unlikely to occur within the code strings
    - simplify the coded templates with constexpr for the SHA1sum
    - Correct the CodedSource to use 'codeConstrain' instead of
      'codeSetValue' for consistency with the underlying functions.
dynamicCodeContext.H 5.12 KB