Will Bainbridge authored 7 years ago and Andrew Heather committed 7 years ago

Tracking data classes are no longer templated on the derived cloud type.
The advantage of this is that they can now be passed to sub models. This
should allow continuous phase data to be removed from the parcel
classes. The disadvantage is that every function which once took a
templated TrackData argument now needs an additional TrackCloudType
argument in order to perform the necessary down-casting.

Will Bainbridge authored 7 years ago and Andrew Heather committed 7 years ago

Resolves bug report https://bugs.openfoam.org/view.php?id=2680

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Resolves bug-report https://bugs.openfoam.org/view.php?id=2677

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

The combined solver includes the most advanced and general functionality from
each solver including:

    Continuous phase
    Lagrangian multiphase parcels
    Optional film
    Continuous and Lagrangian phase reactions
    Radiation
    Strong buoyancy force support by solving for p_rgh

The reactingParcelFoam and reactingParcelFilmFoam tutorials have been combined
and updated.

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Description
    The Foam::Function1 temperature-dependent viscosity model multiplies the
    viscosity of a base model by a Function1 temperature function.

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Resolves bug-report https://bugs.openfoam.org/view.php?id=2605

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

for consistency with reactingTwoPhaseEulerFoam and to ensure correct operation
of models requiring formal boundedness of phase-fractions.

Resolves bug-report https://bugs.openfoam.org/view.php?id=2589

INT: updated overInterDyMFoam and MPPICInterFoam following changes to multiphase solvers.  Needs further testing

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

using the continuity error correction formulation developed for
twoPhaseEulerFoam and reactingEulerFoam.

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Resolves bug-report https://bugs.openfoam.org/view.php?id=2632

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Resolves bug-report https://bugs.openfoam.org/view.php?id=2629

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Temporal variation of Ta is generally more useful than spatial variation but
a run-time switch between the two modes of operation could be implemented in
needed.

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

"pos" now returns 1 if the argument is greater than 0, otherwise it returns 0.
This is consistent with the common mathematical definition of the "pos" function:

https://en.wikipedia.org/wiki/Sign_(mathematics)

However the previous implementation in which 1 was also returned for a 0
argument is useful in many situations so the "pos0" has been added which returns
1 if the argument is greater or equal to 0.  Additionally the "neg0" has been
added which returns 1 if if the argument is less than or equal to 0.

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Now the "localEuler" ddt scheme does not apply any corrections due to
mesh-motion; the old-time volumes are not used and the mesh-motion flux is set
to zero.  A consequence of these changes is that boundedness of transported
scalars is ensured but mesh-motion causes a conservation error which will
reduces to zero as steady-state is approached and the mesh becomes stationary.

mattijs authored 7 years ago and Andrew Heather committed 7 years ago

Patch contributed by Mattijs Janssens
Resolves bug-report https://bugs.openfoam.org/view.php?id=2621

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Patch Contributed by Karl Meredith, FM Global.
Resolves bug-report https://bugs.openfoam.org/view.php?id=2621

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Avoids potential problems with derived classes which do not define a clone function.

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Resolves bug-report https://bugs.openfoam.org/view.php?id=2667

Henry Weller authored 7 years ago and Andrew Heather committed 7 years ago

Patch contributed by Timo Niemi, VTT.
Resolves bug-report https://bugs.openfoam.org/view.php?id=2645

Original commit message:
------------------------

Parallel IO: New collated file format

When an OpenFOAM simulation runs in parallel, the data for decomposed fields and
mesh(es) has historically been stored in multiple files within separate
directories for each processor.  Processor directories are named 'processorN',
where N is the processor number.

This commit introduces an alternative "collated" file format where the data for
each decomposed field (and mesh) is collated into a single file, which is
written and read on the master processor.  The files are stored in a single
directory named 'processors'.

The new format produces significantly fewer files - one per field, instead of N
per field.  For large parallel cases, this avoids the restriction on the number
of open files imposed by the operating system limits.

The file writing can be threaded allowing the simulation to continue running
while the data is being written to file.  NFS (Network File System) is not
needed when using the the collated format and additionally, there is an option
to run without NFS with the original uncollated approach, known as
"masterUncollated".

The controls for the file handling are in the OptimisationSwitches of
etc/controlDict:

OptimisationSwitches
{
    ...

    //- Parallel IO file handler
    //  uncollated (default), collated or masterUncollated
    fileHandler uncollated;

    //- collated: thread buffer size for queued file writes.
    //  If set to 0 or not sufficient for the file size threading is not used.
    //  Default: 2e9
    maxThreadFileBufferSize 2e9;

    //- masterUncollated: non-blocking buffer size.
    //  If the file exceeds this buffer size scheduled transfer is used.
    //  Default: 2e9
    maxMasterFileBufferSize 2e9;
}

When using the collated file handling, memory is allocated for the data in the
thread.  maxThreadFileBufferSize sets the maximum size of memory in bytes that
is allocated.  If the data exceeds this size, the write does not use threading.

When using the masterUncollated file handling, non-blocking MPI communication
requires a sufficiently large memory buffer on the master node.
maxMasterFileBufferSize sets the maximum size in bytes of the buffer.  If the
data exceeds this size, the system uses scheduled communication.

The installation defaults for the fileHandler choice, maxThreadFileBufferSize
and maxMasterFileBufferSize (set in etc/controlDict) can be over-ridden within
the case controlDict file, like other parameters.  Additionally the fileHandler
can be set by:
- the "-fileHandler" command line argument;
- a FOAM_FILEHANDLER environment variable.

A foamFormatConvert utility allows users to convert files between the collated
and uncollated formats, e.g.
    mpirun -np 2 foamFormatConvert -parallel -fileHandler uncollated

An example case demonstrating the file handling methods is provided in:
$FOAM_TUTORIALS/IO/fileHandling

The work was undertaken by Mattijs Janssens, in collaboration with Henry Weller.