- Dec 06, 2018
-
-
Andrew Heather authored
ENH: isoSurfaceTopo: replacement for isoSurfaceCell. See merge request OpenFOAM-plus!224
-
-
Andrew Heather authored
ENH: update handling of versioning and make control (issue #1010) See merge request OpenFOAM-plus!222
-
- Dec 05, 2018
-
-
Mark OLESEN authored
-
Mark OLESEN authored
-
Mark OLESEN authored
-
Mark OLESEN authored
- now placed under postProcessing/checkMesh and postProcessing/checkAMI, respectively. Output files are now also tagged with the id of the patch, in case there are multiple AMI patches in use.
-
Mark OLESEN authored
- the problem occurred when running the writers in a parallel solver or utility but requesting output on the master only. Adjusted the logic to avoid globalIndex for these cases. Previously the if (parallel_) checks were happening later, after the globalIndex had already been created.
-
Mark OLESEN authored
- the previous 9.0.0 was a premature change from ParaView 5.5 and still will not be reached for a while
-
Mark OLESEN authored
- use cellCentres() instead of volField equivalent for vtk conversion - make looping variables more consistent - centralize the transcription of OpenFOAM -> vtk tuples
-
Mark OLESEN authored
- now consider options '-hostRoots', '-roots' to be advanced options that don't need to be in the cache
-
Mark OLESEN authored
-
- Dec 04, 2018
-
-
Mark OLESEN authored
- The usage claimed '-output=', but was using '--output=' for the output file. Rectify to use single dash as documented.
-
Andrew Heather authored
ENH: momentum field function (issue #1105) See merge request OpenFOAM-plus!223
-
Mark OLESEN authored
Calculates linear/angular momentum, reporting integral values and optionally writing the fields. Example momentum1 { type momentum; libs ("libfieldFunctionObjects.so"); ... writeMomentum yes; writeVelocity no; cylindrical true; origin (0 0 0); e1 (1 0 0); e3 (0 0 1); }
-
Mark OLESEN authored
-
Mark OLESEN authored
-
Mark OLESEN authored
- eg for foamVersion.H
-
- Dec 03, 2018
-
-
Andrew Heather authored
-
Andrew Heather authored
-
Andrew Heather authored
-
Andrew Heather authored
-
Andrew Heather authored
The freestreamFvPatchField previously employed a fixed value when supplying the inlet values. This commit extends the BC so that users can use another patch to supply the values via the new freestreamBC entry, e.g. to set the velocity to an atmospheric boundary layer profile: inlet { type freestream; freestreamBC { type atmBoundaryLayerInletVelocity; flowDir (1 0 0); zDir (0 0 1); Uref 20; Zref 20; z0 uniform 0.1; zGround uniform 935; } } The earlier specification is also maintained for backwards compatibility, e.g. inlet { type freestream; freestreamValue uniform (300 0 0); }
-
Mark OLESEN authored
- provide default WM_DIR if not already set, to improve robustness if a reduced environment is used - add etc/ to WM_PROJECT_SITE search. This makes the site directory structure consistent with the OpenFOAM structure. Eg, WM_PROJECT_SITE/etc/.. WM_PROJECT_SITE/bin/.. WM_PROJECT_SITE/platforms/.. - Don't set/export WM_OSTYPE. The default is POSIX and is properly defaulted throughout, including in CMakeLists-OpenFOAM.txt (also for Catalyst)
-
mattijs authored
-
- Dec 02, 2018
-
-
Mark OLESEN authored
- Use the OPENFOAM define (eg, 1806, 1812), which normally corresponds to a major release, to define an API level. This remains consistent within a release cycle and means that it is possible to manage several sub-versions and continue to have a consistent lookup. The current API value is updated automatically during the build and cached as meta data for later use, even when the wmake/ directory is missing or OpenFOAM has not yet be initialized. The version information reported on program start or with -help usage adjusted to reflect this. The build tag from git now also carries the date as being more meaningful to trace than a hash value. - Update etc/bashrc and etc/cshrc to obtain the project directory directly instead of via its prefix directory. The value obtained corresponds to an absolute path, from which the prefix directory can be obtained. The combination of these changes removes the reliance on any particular directory naming convention. For example, With an 1812 version (API level): WM_PROJECT_VERSION=myVersion installed as /some/path/somewhere/openfoam-mySandbox This makes the -prefix, -foamInstall, -projectVersion, -version values of foamEtcFiles, and similar entries for foamConfigurePaths superfluous. WM_PROJECT_INST_DIR is no longer required or used ENH: improve handling and discovery of ThirdParty - improve the flexibility and reusability of ThirdParty packs to cover various standard use cases: 1. Unpacking initial release tar files with two parallel directories - OpenFOAM-v1812/ - ThirdParty-v1812/ 2. With an adjusted OpenFOAM directory name, for whatever reason - OpenFOAM-v1812-myCustom/ - openfoam-1812-other-info/ 3. Operating with/without ThirdParty directory To handle these use cases, the following discovery is used. Note PROJECT = the OpenFOAM directory `$WM_PROJECT_DIR` PREFIX = the parent directory VERSION = `$WM_PROJECT_VERSION` API = `$WM_PROJECT_API`, as per `foamEtcFiles -show-api` 0. PROJECT/ThirdParty - for single-directory installations 1. PREFIX/ThirdParty-VERSION - this corresponds to the traditional approach 2. PREFIX/ThirdParty-vAPI - allows for an updated value of VERSION (eg, v1812-myCustom) without requiring a renamed ThirdParty. The API value would still be '1812' and the original ThirdParty-v1812/ would be found. 3. PREFIX/ThirdParty-API - this is the same as the previous example, but using an unadorned API value. This also makes sense if the chosen version name also uses the unadorned API value in its naming (eg, 1812-patch190131, 1812.19W03) 4. PREFIX/ThirdParty-common - permits maximum reuse for various versions, but only for experienced user who are aware of potential version incompatibilities Directory existence is checked as is the presence of an Allwmake file or a platforms/ directory. This reduces the potential of false positive matches and limits the selection to directories that are either with sources (has the Allwmake file), or pre-compiled binaries (has the platforms/ directory). If none of the explored directories are found to be suitable, it reverts to using a PROJECT/ThirdParty dummy location since this is within the project source tree and can be trusted to have no negative side-effects. ENH: add csh support to foamConfigurePaths - this removes the previously experienced inconsistence in config file contents. REMOVED: foamExec - was previously used when switching versions and before the bashrc/cshrc discovery logic was added. It is now obsolete.
-
- Nov 29, 2018
-
-
mattijs authored
-
- Dec 02, 2018
-
-
Mark OLESEN authored
- Uses the user-specified value for outputTemperature: { type externalCoupledTemperature; outputTemperture fluid; // or wall; } Otherwises uses 'wall' as a default (for compatibility) and emits a warning. The T.out header now reflects the type of output. Eg, # Values: area Tfluid qDot htc
-
Mark OLESEN authored
- tutorials based on squareBend used Default_Boundary_Region explicitly defined since they predated the defaultPatch renaming (2008). The name 'Default_Boundary_Region' was for convenience as the default name when converting to PROSTAR or CCM formation, but can now be changed to something more generic. - define wall boundary conditions for squareBend using a general regex to allow future splitting of wall types by name.
-
- Nov 30, 2018
-
-
Mark OLESEN authored
- check if the first argument corresponds to an OpenFOAM value for 'true' (as per Switch). True == 't', 'y', 'true', 'yes', 'on'. Everything else is not true. - when the first argument is '-dict', it initializes the value with a query via foamDictionary. Eg, isTrue -dict mydict -entry parallel ==> value=$(foamDictionary mydict -entry parallel -value) isTrue $value a missing entry is silently treated as false. ENH: add getNumberOfPatchFaces function in RunFunctions - simple extraction of nFaces from boundary file for given patch/region
-
- Dec 02, 2018
-
-
Mark OLESEN authored
-
- Nov 29, 2018
-
-
Mark OLESEN authored
-
Mark OLESEN authored
- append the commit hash value with the commit date when creating the build string information and drop the version prefix. This provides an immediate overview of when the code was last changed. The prefixed version information can be dropped from the build string, since it is readily available in other forms.
-
Mark OLESEN authored
- this splits a larger changeset for a gradual implementation
-
Mark OLESEN authored
- was PREFIX/site, now PROJECT/site This avoids several issues when installing OpenFOAM in clusters without an intermediate OpenFOAM-specific installation prefix. The 'site' directory may have a reserved meaning in these situations and it is undesirable to 'leak' upwards into the parent directory to look for configuration files. Placing the default within the project directory avoids this. Alternative locations can be given via the WM_PROJECT_SITE variable.
-
Mark OLESEN authored
- comments in bashrc, cshrc. - about controlDict names for allowSystemOperations
-
Mark OLESEN authored
-
Mark OLESEN authored
-
Mark OLESEN authored
- removed reliance on ParaView_INCLUDE_DIR variable for conveying the major.minor version information when compiling. This can be somewhat fragile and also adds variable that is an unnecessary when running (only used when compiling). Instead use `have_pvplugin_support` function in paraviewFunctions wmake script to determine the maj.min from the PV_PLUGIN_PATH since we have already defined the output path there with paraview maj.min numbering. Can now build with paraview from the operating system, provided that it has develop headers available. ParaView_VERSION=system In the etc/config.sh/paraview setup, the maj.min is taken from the corresponding `paraview --version` output and used when defining the PV_PLUGIN_PATH. During the build, the include path taken from `paraview-config` for a system installation, from the guess installation root of the paraview binary, or ParaView_DIR otherwise. NB: using a system ParaView for building runTimePostProcessing is unsupported. - these types of builds appear to have various library resolution issues (eg, libexpat not being loaded). Additionally, the build logic does not yet cover this type of use case.
-
- Nov 28, 2018
-
-
Mark OLESEN authored
- skip /, /bin, /usr/bin ... as potential filters.
-